chiark / gitweb /
Lennart Poettering [Mon, 9 Dec 2013 22:03:21 +0000 (23:03 +0100)]
bus: demarshal gvariant
Lennart Poettering [Mon, 9 Dec 2013 21:51:35 +0000 (22:51 +0100)]
extend CODING_STYLE document a bit
Zbigniew Jędrzejewski-Szmek [Sun, 8 Dec 2013 23:56:16 +0000 (18:56 -0500)]
man: document 'is-enabled' output
https://bugzilla.redhat.com/show_bug.cgi?id=953077
Zbigniew Jędrzejewski-Szmek [Sun, 8 Dec 2013 22:51:25 +0000 (17:51 -0500)]
systemctl: fix 'is-enabled'
Zbigniew Jędrzejewski-Szmek [Sun, 8 Dec 2013 22:50:25 +0000 (17:50 -0500)]
systemctl: simplify argument parsing
Zbigniew Jędrzejewski-Szmek [Sun, 8 Dec 2013 13:16:59 +0000 (08:16 -0500)]
Help output spring cleaning
Use [brackets] only for optional elements.
Use <optional> in XML sources.
Zbigniew Jędrzejewski-Szmek [Sun, 8 Dec 2013 12:46:46 +0000 (07:46 -0500)]
kernel-install: add -h/--help
Zbigniew Jędrzejewski-Szmek [Sun, 8 Dec 2013 11:46:07 +0000 (06:46 -0500)]
Trim TODO
Thomas Hindoe Paaboel Andersen [Sun, 8 Dec 2013 21:28:37 +0000 (22:28 +0100)]
bootchart: remove dead assignment
Dan McGee [Sun, 8 Dec 2013 20:33:45 +0000 (14:33 -0600)]
Fix memory leak in stdout journal streams
Just as 'identifier' is strdup-ed and freed, we need to do the same for
unit_id.
Kay Sievers [Sun, 8 Dec 2013 05:36:39 +0000 (06:36 +0100)]
test: cgroup-util - do not fail if cpu controller is not available
Thomas Hindoe Paaboel Andersen [Sat, 7 Dec 2013 20:53:37 +0000 (21:53 +0100)]
systemctl: fix and refactor wait_for_jobs
wait_for_jobs was ignoring the errors from the jobs stored in r.
It would only ever return whether the call to sd_bus_remove_filter
went ok. This patch changes it to return the first job related error
encountered. If a job related error is found, then the result of the
call to sd_bus_remove_filter is ignored.
wait_for_jobs was a bit hard to read so I split it up to avoid
the goto and deep nesting.
Zbigniew Jędrzejewski-Szmek [Sat, 7 Dec 2013 02:29:55 +0000 (21:29 -0500)]
systemctl: allow globbing in list-<whatever> commands
It is nicer to say 'systemctl list-units ssh\*' then to use grep,
because colouring is preserved and it is easier to match just against
the unit name.
Zbigniew Jędrzejewski-Szmek [Sat, 7 Dec 2013 02:29:55 +0000 (21:29 -0500)]
Get rid of our reimplementation of basename
The only problem is that libgen.h #defines basename to point to it's
own broken implementation instead of the GNU one. This can be fixed
by #undefining basename.
Thomas Hindoe Paaboel Andersen [Fri, 6 Dec 2013 18:48:08 +0000 (19:48 +0100)]
systemctl: check the value from start_unit_one
introduced in
f459b6025f9368116d8c410376546c157314c205
Kay Sievers [Fri, 6 Dec 2013 20:11:37 +0000 (21:11 +0100)]
bus: catch up with latest kdbus changes
Kay Sievers [Fri, 6 Dec 2013 19:19:20 +0000 (20:19 +0100)]
bus: catch up with latest kdbus changes
Bastien Nocera [Fri, 6 Dec 2013 14:51:02 +0000 (15:51 +0100)]
rfkill: Avoid error when state restore is disabled
When the state restore is disabled, we would print:
"Unknown verb: load" instead of simply skipping loading the
state.
Kay Sievers [Fri, 6 Dec 2013 13:31:43 +0000 (14:31 +0100)]
bus: catch up with latest kdbus changes
Kay Sievers [Fri, 6 Dec 2013 12:56:23 +0000 (13:56 +0100)]
busctl: remove ','; it's all one string
Shawn Landden [Thu, 5 Dec 2013 14:20:08 +0000 (06:20 -0800)]
nspawn: fix buggy mount_binds, now works for bind-mounted files
Yuxuan Shui [Thu, 5 Dec 2013 14:30:04 +0000 (22:30 +0800)]
util: fix misuse of memcmp
Zbigniew Jędrzejewski-Szmek [Fri, 6 Dec 2013 02:33:08 +0000 (21:33 -0500)]
shell-completion: busctl
Kay Sievers [Fri, 6 Dec 2013 00:30:59 +0000 (01:30 +0100)]
bus: update kdbus.h
Zbigniew Jędrzejewski-Szmek [Thu, 5 Dec 2013 05:41:12 +0000 (00:41 -0500)]
systemd: add a start job for all units in SYSTEMD_[USER_]WANTS=
Thomas Hindoe Paaboel Andersen [Thu, 5 Dec 2013 21:34:01 +0000 (22:34 +0100)]
execute.h: remove redefinition of Unit
Unit is typedef'ed in both unit.h and execute.h. The typedef
existed first in unit.h and was later added to execute.h in
c17ec25e4d9bd6c8e8617416f813e25b2ebbafc5
It is no longer needed so let's just keep the one in unit.h to
avoid redefining it.
Thomas Hindoe Paaboel Andersen [Thu, 5 Dec 2013 21:33:22 +0000 (22:33 +0100)]
test-bus-gvariant: remove unused variable
Lennart Poettering [Thu, 5 Dec 2013 02:16:15 +0000 (03:16 +0100)]
bus: start maintaining a list of difference between kdbus/dbus1
Lennart Poettering [Thu, 5 Dec 2013 02:09:09 +0000 (03:09 +0100)]
bus: add missing LE meta data enforcement for gvariant serializer
Lennart Poettering [Thu, 5 Dec 2013 01:48:17 +0000 (02:48 +0100)]
busname: improve condition check
Lennart Poettering [Thu, 5 Dec 2013 01:46:54 +0000 (02:46 +0100)]
bus: add support for serializing to gvariant
(deserialization is still missing, hence this is not hooked up to kdbus)
Kay Sievers [Wed, 4 Dec 2013 22:36:02 +0000 (23:36 +0100)]
bus: switch to multiple KDBUS_ITEM_NAME including the flags
Alex Jia [Wed, 4 Dec 2013 07:57:50 +0000 (15:57 +0800)]
man.systemd-cgls: Fix an option typo
The option 'M' is inconsistent between help document and man page.
Thomas Hindoe Paaboel Andersen [Wed, 4 Dec 2013 22:00:05 +0000 (23:00 +0100)]
README: remove obsolete paragraph about D-Bus
Thomas Hindoe Paaboel Andersen [Wed, 4 Dec 2013 19:51:03 +0000 (20:51 +0100)]
systemctl: make an always true assert static
Silences a warning i clang
Thomas Hindoe Paaboel Andersen [Wed, 4 Dec 2013 19:01:07 +0000 (20:01 +0100)]
systemctl: no need to fdopen stdout
Kay Sievers [Wed, 4 Dec 2013 18:06:52 +0000 (19:06 +0100)]
libsystemd-bus: catch up with latest kdbus changes
David Coppa [Wed, 4 Dec 2013 11:59:40 +0000 (12:59 +0100)]
Fix typo: SetChasis -> SetChassis
Tom Gundersen [Wed, 4 Dec 2013 12:14:23 +0000 (13:14 +0100)]
TODO: add networkd entries
Tom Gundersen [Tue, 3 Dec 2013 17:48:20 +0000 (18:48 +0100)]
networkd: add link-sense and simplify state-machine a bit
This listens to rtnetlink for changes to IFF_UP and IFF_LOWER_UP (link sense). The latter
is simply logged at the moment, but will be useful once we add dhcp support.
Tom Gundersen [Tue, 3 Dec 2013 23:34:58 +0000 (00:34 +0100)]
rtnl: add link_get_flags
Tom Gundersen [Sat, 30 Nov 2013 00:24:29 +0000 (01:24 +0100)]
rtnl: add callback support
sd_rtnl_add_match allows you to add a callback function for when given types of
messages are received.
Tom Gundersen [Tue, 3 Dec 2013 22:55:45 +0000 (23:55 +0100)]
rtnl: don't ignore broadcast messages
Kay Sievers [Wed, 4 Dec 2013 10:47:22 +0000 (11:47 +0100)]
libsystemd-bus: catch up with latest kdbus list query changes
Thomas Hindoe Paaboel Andersen [Tue, 3 Dec 2013 21:27:45 +0000 (22:27 +0100)]
trivial coding style clean ups
- Add space between if/for and the opening parentheses
- Place the opening brace on same line as the function (not for udev)
From the CODING_STYLE
Try to use this:
void foo() {
}
instead of this:
void foo()
{
}
Thomas Hindoe Paaboel Andersen [Tue, 3 Dec 2013 20:58:51 +0000 (21:58 +0100)]
sd-memfd: use assert_return
Lennart Poettering [Tue, 3 Dec 2013 19:31:34 +0000 (20:31 +0100)]
bus: fix parsing of AcquireName() response
Lennart Poettering [Tue, 3 Dec 2013 18:55:51 +0000 (19:55 +0100)]
bus: don't make use of the private bus socket if kdbus is available
Lennart Poettering [Tue, 3 Dec 2013 17:58:18 +0000 (18:58 +0100)]
core: use normal library call to query list of current names
Lennart Poettering [Tue, 3 Dec 2013 17:42:51 +0000 (18:42 +0100)]
bus: rework sd_bus_list_names() to return two lists for acquired and activatable names
Lennart Poettering [Tue, 3 Dec 2013 17:13:48 +0000 (18:13 +0100)]
bus: internalize a lot of protocol definitions
We shouldn export what isn't necessary or useful to clients, so let's
add the protocol definitions we only need internally into a private
header.
Zbigniew Jędrzejewski-Szmek [Tue, 3 Dec 2013 13:07:32 +0000 (08:07 -0500)]
journal: fail silently in sd_j_sendv() if journal is unavailable
"syslog(3) and sd_journal_print() may largely be used interchangeably
functionality-wise" according to sd_journal_print(3). This socket
should be always available except in rare circumstatances, and we
don't random applications to fail on logging, so let's do what syslog
did. The alternative of forcing all callers to do error handling for
this rare case doesn't really have any benefits, since if they can't
log there isn't much they can do anyway.
https://bugzilla.redhat.com/show_bug.cgi?id=
1023041
Lennart Poettering [Tue, 3 Dec 2013 17:01:26 +0000 (18:01 +0100)]
bus: make sd_bus_request_name() and sd_bus_release_name() behave more like other calls
Instead of returning an enum of return codes, make them return error
codes like kdbus does internally.
Also, document this behaviour so that clients can stick to it.
(Also rework bus-control.c to always have to functions for dbus1 vs.
kernel implementation of the various calls.)
Lennart Poettering [Tue, 3 Dec 2013 15:41:06 +0000 (16:41 +0100)]
macro: better make IN_SET() macro use const arrays
Daniel Mack [Tue, 3 Dec 2013 13:38:53 +0000 (14:38 +0100)]
libsystemd-bus: catch up with latest kdbus changes
Lennart Poettering [Tue, 3 Dec 2013 03:27:03 +0000 (04:27 +0100)]
units: ship busname units for the bus activated services we ship
Zbigniew Jędrzejewski-Szmek [Tue, 3 Dec 2013 01:29:10 +0000 (20:29 -0500)]
catalog: rename files to specify language in the filename
Zbigniew Jędrzejewski-Szmek [Tue, 3 Dec 2013 02:35:31 +0000 (21:35 -0500)]
catalog: determine language from the filename
Zbigniew Jędrzejewski-Szmek [Tue, 3 Dec 2013 02:52:51 +0000 (21:52 -0500)]
systemd: treat reload failure as failure
systemctl reload "suceeded" on stopped units, but it is documented
to fail in this case.
https://bugzilla.redhat.com/show_bug.cgi?id=
1036845
Lennart Poettering [Tue, 3 Dec 2013 01:07:24 +0000 (02:07 +0100)]
dbus1: make gcc shut up
Daniel Mack [Tue, 3 Dec 2013 00:56:13 +0000 (01:56 +0100)]
libsystemd-bus: catch up with latest kdbus changes
Lennart Poettering [Tue, 3 Dec 2013 00:44:24 +0000 (01:44 +0100)]
units: create busnames.target for user sessions too
Lennart Poettering [Tue, 3 Dec 2013 00:41:02 +0000 (01:41 +0100)]
dbus1: hook busnames.target into normal boot if kdbus is enabled
Lennart Poettering [Tue, 3 Dec 2013 00:24:39 +0000 (01:24 +0100)]
bus: skip unit file generation for systemd itself
Lennart Poettering [Tue, 3 Dec 2013 00:18:26 +0000 (01:18 +0100)]
units: install busnames.target by default
Lennart Poettering [Tue, 3 Dec 2013 00:13:03 +0000 (01:13 +0100)]
bus: add generator that turns old dbus1 activation files into .busname + .service units
Lennart Poettering [Mon, 2 Dec 2013 22:30:19 +0000 (23:30 +0100)]
bus: add .busname unit type to implement kdbus-style bus activation
Lennart Poettering [Mon, 2 Dec 2013 22:31:41 +0000 (23:31 +0100)]
bus: make sure we check for "incompatible" flags negotiated with kernel kdbus
Lennart Poettering [Mon, 2 Dec 2013 22:10:28 +0000 (23:10 +0100)]
core: extra paranoia when deserializing kdbus fd
Lennart Poettering [Mon, 2 Dec 2013 22:08:25 +0000 (23:08 +0100)]
macro: add a macro to test whether a value is in a specified list
Introduce IN_SET() macro to nicely check whether a value a is one of a
few listed values.
This makes writing this:
if (a == 1 || a == 7 || a == 8 || a == 9)
nicer, by allowing this:
if (IN_SET(a, 1, 7, 8, 9))
This is particularly useful for state machine enums.
Thomas Hindoe Paaboel Andersen [Mon, 2 Dec 2013 21:42:01 +0000 (22:42 +0100)]
Use assert_return in more of the public API
Daniel Mack [Mon, 2 Dec 2013 19:29:58 +0000 (20:29 +0100)]
libsystemd-bus: catch up with latest kdbus changes
Lennart Poettering [Mon, 2 Dec 2013 18:59:15 +0000 (19:59 +0100)]
nspawn: make sure /dev/kdbus in the container is world accessible
Lennart Poettering [Mon, 2 Dec 2013 17:47:39 +0000 (18:47 +0100)]
nspawn: make kdbus namespaces actually work
Lennart Poettering [Mon, 2 Dec 2013 17:40:19 +0000 (18:40 +0100)]
busctl: add command to dump creds of a peer or pid
(also, rename _SD_BUS_CREDS_MAX to _SD_BUX_CRED_ALL, since "MAX" so far
was used to indicate one higher than the highest valid value, and this
is not correct here.)
Lukasz Skalski [Mon, 2 Dec 2013 15:31:46 +0000 (16:31 +0100)]
Display synthetic message serial number in a more readable format than (uint32_t) -1
Serial=
4294967295 field in message dump generated by bus_message_dump()
function for synthetic messages isn't good readable.
Lennart Poettering [Mon, 2 Dec 2013 16:17:29 +0000 (17:17 +0100)]
bus: be nice to LLVM and don't embedd a VLA in a union
Lennart Poettering [Mon, 2 Dec 2013 14:28:20 +0000 (15:28 +0100)]
bus: when replying to an incoming message and the vtable contains the expected return signature generate an error if the response message doesn't match it
Shawn Landden [Wed, 20 Nov 2013 08:35:04 +0000 (00:35 -0800)]
service: remove unneccesary Socket.got_socket_fd
Marcel Holtmann [Sun, 1 Dec 2013 20:28:32 +0000 (12:28 -0800)]
build-sys: allow building systemctl with --disable-logind
When logind is disabled, do not attempt to link against the non-existing
libsystemd-login-internal.la library.
Kay Sievers [Sun, 1 Dec 2013 17:17:21 +0000 (18:17 +0100)]
bus: bus_open_user_systemd() fall back to bus if runtime dir is not set
Daniele Medri [Thu, 28 Nov 2013 17:58:55 +0000 (18:58 +0100)]
catalog,po: add Italian translation
David Herrmann [Sat, 30 Nov 2013 10:31:59 +0000 (11:31 +0100)]
util: add greedy_realloc0()
Compared to greedy_realloc(), this sets all newly allocated memory to 0.
As the old variant has been used a lot for string-handling, we avoid
changing it as clearing memory is not needed there.
David Herrmann [Sat, 30 Nov 2013 10:37:32 +0000 (11:37 +0100)]
logind: fix "CanGraphical" attribute to return correct value
We should return seat_can_graphical() instead of seat_can_tty() for the
public dbus CanGraphical attribute. This used to work, but the
dbus -> sd-bus conversion introduced this regression.
Shawn Landden [Sun, 1 Dec 2013 04:02:27 +0000 (20:02 -0800)]
fix regression of read_full_file() in fileio.c
my
e93c33d4aa broke this stupidly
Zbigniew Jędrzejewski-Szmek [Sun, 1 Dec 2013 03:31:31 +0000 (22:31 -0500)]
shell-completion: systemctl cat
Also update -H help string to follow the binaries.
Zbigniew Jędrzejewski-Szmek [Sun, 1 Dec 2013 03:29:33 +0000 (22:29 -0500)]
systemctl: do not show SourcePath when FragmentPath cannot be found
Those files can be in a completely deferent format and also
arbitrarily long, and usually contain information about other
stuff. If we ever add SourceLine= or SourceLines= in addition
to SourcePath=, and can show the relevant information only, this
commit can be reverted.
Shawn Landden [Sun, 1 Dec 2013 00:09:26 +0000 (16:09 -0800)]
systemctl: add "systemctl cat"
Shawn Landden [Sun, 24 Nov 2013 03:52:52 +0000 (19:52 -0800)]
systemctl: refactor show()
v2, don't leave in unused function
Zbigniew Jędrzejewski-Szmek [Sun, 1 Dec 2013 02:23:01 +0000 (21:23 -0500)]
man: explicitly say when multiple units can be specified
itistoday> how do you specify multiple dependencies in a unit file? i've been
googling and can't find this basic thing :-\
itistoday> do you use a comma, or use multiple After= statements?
Zbigniew Jędrzejewski-Szmek [Sun, 1 Dec 2013 01:27:54 +0000 (20:27 -0500)]
docs: remove unneeded the's in gudev docs
https://bugs.freedesktop.org/show_bug.cgi?id=72164
Zbigniew Jędrzejewski-Szmek [Sun, 1 Dec 2013 01:10:18 +0000 (20:10 -0500)]
bus: remove unused variable
Thomas Hindoe Paaboel Andersen [Sat, 30 Nov 2013 23:26:08 +0000 (00:26 +0100)]
bus: remove unused variable
Thomas Hindoe Paaboel Andersen [Sat, 30 Nov 2013 22:45:31 +0000 (23:45 +0100)]
util.c: check if return value from ttyname_r is > 0 instead of != 0
We must return a negative error code from getttyname_malloc but
that would not be the case if ttyname_r returned a negative value.
ttyname_r should only return EBADF, ENOTTY, or ERANGE so it should
be safe to change.
Thomas Hindoe Paaboel Andersen [Sat, 30 Nov 2013 20:59:40 +0000 (21:59 +0100)]
sysfs-show.c: return negative error
introduced in
1ca208fb4f93e5869704af1812cbff7130a2fc03
Thomas Hindoe Paaboel Andersen [Sat, 30 Nov 2013 20:55:35 +0000 (21:55 +0100)]
macro.h: fix typo in comment
Kay Sievers [Sat, 30 Nov 2013 19:41:02 +0000 (20:41 +0100)]
bus: catch up with kdbus
Lennart Poettering [Sat, 30 Nov 2013 19:18:48 +0000 (20:18 +0100)]
bus: do kdbus only if this is enabled on the configure switch
Since we want to retain the ability to break kernel ←→ userspace ABI
after the next release, let's not make use by default of kdbus, so that
people with future kernels will not suddenly break with current systemd
versions.
kdbus support is left in all builds but must now be explicitly requested
at runtime (for example via setting $DBUS_SESSION_BUS). Via a configure
switch the old behaviour can be restored. In fact, we change autogen.sh
to do this, so that git builds (which run autogen.sh) get kdbus by
default, but tarball builds (which ue the configure defaults) do not get
it, and hence this stays out of the distros by default.
Lennart Poettering [Sat, 30 Nov 2013 18:55:23 +0000 (19:55 +0100)]
update TODO
Lennart Poettering [Sat, 30 Nov 2013 18:53:33 +0000 (19:53 +0100)]
bus: use "System.Error." as prefix for implicit errno bus errors
We probably shouldn't use "Posix.Error" since many of the errors have
nothing to do with Posix.