chiark / gitweb /
greg@kroah.com [Sat, 16 Oct 2004 02:18:25 +0000 (19:18 -0700)]
[PATCH] add debian config files.
taken from latest udev debian package.
greg@kroah.com [Sat, 16 Oct 2004 01:49:27 +0000 (18:49 -0700)]
[PATCH] let the extras/ programs build "pretty" also
patmans@us.ibm.com [Sat, 16 Oct 2004 01:42:53 +0000 (18:42 -0700)]
[PATCH] pass SYSFS setting down for extras builds
Modify SYSFS to specify the full path, and pass it down for the extras
builds.
Change the scsi_id Makefile so it will work with and without udev.
greg@kroah.com [Sat, 16 Oct 2004 01:42:42 +0000 (18:42 -0700)]
[PATCH] tweak the ccdv program to handle files in subdirectories being built.
patmans@us.ibm.com [Sat, 16 Oct 2004 01:18:54 +0000 (18:18 -0700)]
[PATCH] move assignments past local variables
I'm using an older C compiler, and it doesn't like assignments mixed with
declarations, but this is also a style cleanup.
greg@kroah.com [Sat, 16 Oct 2004 00:15:52 +0000 (17:15 -0700)]
[PATCH] crap, I messed up the 'sed' instances pretty badly, this fixes the config and man page mess.
kay.sievers@vrfy.org [Fri, 15 Oct 2004 03:36:12 +0000 (20:36 -0700)]
[PATCH] wait_for_sysfs update for /class/firmware and /class/net/irda devices
update for /class/firmware and /class/net/irda devices
kay.sievers@vrfy.org [Fri, 15 Oct 2004 03:36:10 +0000 (20:36 -0700)]
[PATCH] fix unusual sysfs behavior for pcmcia_socket
All files in /sys/class/pcmcia_socket/pcmcia_socket0/* are unreadable
without a card inserted:
read(3, 0x9167858, 4096) = -1 ENODEV (No such device)
So we need to skip that step for now.
kay.sievers@vrfy.org [Fri, 15 Oct 2004 03:36:07 +0000 (20:36 -0700)]
[PATCH] remove sleeps from udev as it is external now
Here we remove all the sysfs sleep loops from udev as wait_for_sysfs
will do this for us and any other hotplug user. We still keep a small
blacklist of subsystems we don't care about but any missing entry here
will no longer lead to a spinning udev waiting for files.
kay.sievers@vrfy.org [Fri, 15 Oct 2004 03:36:04 +0000 (20:36 -0700)]
[PATCH] delete udevruler?
Hey, we got consistent source filenames today. Let's go ahead :)
I once started this ambitiuos curses gui to edit udev rules files.
udevruler still lays dead around in the tree. I will not finish it
and it is not really useful at his state. If nobody wants to do
something for it, I'm for deleting it.
greg@kroah.com [Fri, 15 Oct 2004 02:42:52 +0000 (19:42 -0700)]
[PATCH] fix broken 'make -j5' functionality.
kay.sievers@vrfy.org [Thu, 14 Oct 2004 08:42:33 +0000 (01:42 -0700)]
[PATCH] Makefile fix
Remove the rest of the debian stuff too, to make install working again.
greg@kroah.com [Thu, 14 Oct 2004 07:49:55 +0000 (00:49 -0700)]
[PATCH] 038 release
andrew.patterson@hp.com [Thu, 14 Oct 2004 07:47:38 +0000 (00:47 -0700)]
[PATCH] Problem parsing %s in udev rules
> > > > That explains the spaces. What about stuff trailing %s, if %s does not
> > > > contain spaces. I.e, in the above example, model is ST336753LC and the
> > > > resulting device file is /dev/scsi_disks/some-proceding-stuff-
> > > > ST336753LC.
> > >
> > > I expect the model value has trailing spaces.
> > >
> > > You may look with:
> > > udevinfo -a -p /block/sdX
> >
> > Yes it does, and it seems for most SCSI devices, vendor and model will
> > have trailing spaces.
>
> It all depends on the vendor and model :)
>
> > I have included a patch to udev-036 to deal with
> > this issue. It trims off trailing whitespace for all sysfs attributes.
> > It might be better to trim off leading whitespace as well.
>
> We already trim it off when matching, but we also allow matching if you
> do put the spaces in there. This patch breaks that, right?
Correct, I have a new patch that trims after the comparison, so it
should work in both cases.
greg@kroah.com [Thu, 14 Oct 2004 07:38:08 +0000 (00:38 -0700)]
[PATCH] fix up error in building extras and libsysfs
greg@kroah.com [Thu, 14 Oct 2004 06:58:54 +0000 (23:58 -0700)]
[PATCH] 037 release
greg@kroah.com [Thu, 14 Oct 2004 06:26:05 +0000 (23:26 -0700)]
[PATCH] fix compilation warning in tdb log message.
greg@kroah.com [Thu, 14 Oct 2004 06:22:37 +0000 (23:22 -0700)]
[PATCH] Fix build error with klibc due to recent changes.
greg@kroah.com [Thu, 14 Oct 2004 06:16:02 +0000 (23:16 -0700)]
[PATCH] merge
greg@kroah.com [Thu, 14 Oct 2004 05:52:08 +0000 (22:52 -0700)]
[PATCH] add wait_for_sysfs test script to the tarball to help people debug their boxes.
greg@kroah.com [Thu, 14 Oct 2004 05:51:41 +0000 (22:51 -0700)]
[PATCH] add ipsec to wait_for_sysfs ignore list.
mbuesch@freenet.de [Thu, 14 Oct 2004 05:38:15 +0000 (22:38 -0700)]
[PATCH] fix asmlinkage
This patch fixes the reintroduced bug with the
sig_handler(), if we link against a -mregparm=3 compiled
klibc on i386.
It also fixes some compiler warnings about redefined
asmlinkage on some systems.
Also some (broken?) compilers on distros throw out warnings
if asmlinkage is before "static void". This fixes it, too.
mbuesch@freenet.de [Thu, 14 Oct 2004 05:37:59 +0000 (22:37 -0700)]
[PATCH] fix incompatible pointer type warning
This patch fixes two
warning: assignment from incompatible pointer type
asmlinkage is the reason for the warning. We can
simply cast to avoid it.
It also fixes this warning:
warning: implicit declaration of function `umask'
kay.sievers@vrfy.org [Thu, 14 Oct 2004 06:13:26 +0000 (23:13 -0700)]
[PATCH] prevent deadlocks on an corrupt udev database
Here is the patch, that should prevent all of the known deadlocks with
corrupt tdb databases we discovered.
Thanks to Frank Steiner <fsteiner-mail@bio.ifi.lmu.de>, who tested all this
endlessly with a NFS mounted /dev. The conclusion is, that udev will not work
on filesystems without proper record locking, but we should prevent the
endless loops anyway. This patch implements:
o recovery from a corrupted udev database. udev will continue
without database support now, instead of doing nothing. So the node should
be generated in any case, remove will obviously not work for custom names.
o added iteration limits to the tdb-code at the places we discovered endless
loops. In the case tdb tries to find more than 100.000 entries with the
same hash, we better give up :)
o prevent a {all_partitions} loop caused by corrupt db data
o log all tdb errors to syslog
o switch sleep() to usleep() cause we want to use alarm()
greg@kroah.com [Thu, 14 Oct 2004 05:33:09 +0000 (22:33 -0700)]
[PATCH] a few more Makefile tweaks for the quiet feature.
greg@kroah.com [Thu, 14 Oct 2004 05:28:06 +0000 (22:28 -0700)]
[PATCH] Make the build silent, thanks to a helper program from ncftp
greg@kroah.com [Thu, 14 Oct 2004 04:25:11 +0000 (21:25 -0700)]
[PATCH] rename files to have '_' instead of '-' in them.
We should be consistent in our madness...
greg@kroah.com [Thu, 14 Oct 2004 04:19:49 +0000 (21:19 -0700)]
[PATCH] change max time to wait in wait_for_sysfs to 10 seconds to hopefully handle some slow machines.
greg@kroah.com [Thu, 14 Oct 2004 04:09:28 +0000 (21:09 -0700)]
[PATCH] add support for class/raw/ to wait_for_sysfs
greg@kroah.com [Thu, 14 Oct 2004 04:08:57 +0000 (21:08 -0700)]
[PATCH] fix up Makefile for wait_for_sysfs udev_version.h dependancy
kay.sievers@vrfy.org [Thu, 14 Oct 2004 03:55:01 +0000 (20:55 -0700)]
[PATCH] wait_for_sysfs_update
Here is an update to wait_for_sysfs to print the udev version to syslog,
let hardware net interfaces wait again for the device link and
revert the video4linux to wait for the device. The error here was caused
by a out-of-tree media-driver, that needs the fix, not the our program.
I've added a small comment for that to the log as I expect more of this
to show up and the recent desktop integration work depends heavily on proper
sysfs support, so the drivers should be fixed.
greg@kroah.com [Thu, 14 Oct 2004 03:54:43 +0000 (20:54 -0700)]
[PATCH] remove the debian specific file, as they don't want to share with the rest of the world :(
md@Linux.IT [Thu, 14 Oct 2004 03:53:52 +0000 (20:53 -0700)]
[PATCH] small udev patch
You should also remove etc/dev.d/default/dbus.dev which does not exist
anymore.
BTW, please remove etc/init.d/udev.debian because it is broken.
greg@kroah.com [Wed, 13 Oct 2004 04:50:15 +0000 (21:50 -0700)]
[PATCH] 036 release
greg@kroah.com [Wed, 13 Oct 2004 04:48:49 +0000 (21:48 -0700)]
[PATCH] add the error number to the error message in wait_for_sysfs to help out in debugging problems.
greg@kroah.com [Tue, 12 Oct 2004 07:53:57 +0000 (00:53 -0700)]
[PATCH] 035 release
greg@kroah.com [Tue, 12 Oct 2004 07:47:27 +0000 (00:47 -0700)]
[PATCH] added ieee1394 support to wait_for_sysfs
greg@kroah.com [Tue, 12 Oct 2004 07:16:24 +0000 (00:16 -0700)]
[PATCH] update wait_for_sysfs with a bunch more devices thanks to user reports.
greg@kroah.com [Fri, 8 Oct 2004 07:36:33 +0000 (00:36 -0700)]
[PATCH] 034 release
greg@kroah.com [Fri, 8 Oct 2004 07:28:16 +0000 (00:28 -0700)]
[PATCH] add comment in wait_for_sysfs to explain the structure better.
greg@kroah.com [Fri, 8 Oct 2004 05:26:02 +0000 (22:26 -0700)]
[PATCH] Revert previous dev_d.c change, it's not what is causing HAL problems.
Cset exclude: greg@kroah.com|ChangeSet|
20041007204001|14326
greg@kroah.com [Fri, 8 Oct 2004 04:40:01 +0000 (21:40 -0700)]
[PATCH] hm, somethings odd with DEVPATH, see if this fixes it...
greg@kroah.com [Fri, 8 Oct 2004 04:39:40 +0000 (21:39 -0700)]
[PATCH] 33_bk mark for the makefile
greg@kroah.com [Fri, 8 Oct 2004 04:06:07 +0000 (21:06 -0700)]
[PATCH] wait_for_sysfs: clean up the logic for the list of devices that we do not expect device symlinks for
This makes it a lot easier to test for these devices, otherwise the list would have gotten very large
greg@kroah.com [Fri, 8 Oct 2004 03:56:08 +0000 (20:56 -0700)]
[PATCH] get rid of annoying extra lines in the syslog for some libsysfs debug messages.
greg@kroah.com [Fri, 8 Oct 2004 02:12:10 +0000 (19:12 -0700)]
[PATCH] added support for i2c devices in wait_for_sysfs.c
greg@kroah.com [Fri, 8 Oct 2004 01:43:31 +0000 (18:43 -0700)]
[PATCH] add support for i2c-adapter devices to wait_for_sysfs.c
kay.sievers@vrfy.org [Thu, 7 Oct 2004 08:34:31 +0000 (01:34 -0700)]
[PATCH] wait_for_sysfs bluetooth class update
Here is the file to wait for the bluetooth class, as it is not a "dev"
file. udev waits for 10 seconds here too.
greg@kroah.com [Thu, 7 Oct 2004 07:27:03 +0000 (00:27 -0700)]
[PATCH] 033 release
kay.sievers@vrfy.org [Thu, 7 Oct 2004 07:17:11 +0000 (00:17 -0700)]
[PATCH] fix problems with dev.d and udevstart
Here is the correction for the dev.d/ scripts too. We should pass
the right argv[0] here too. A script may depend on the right value, as
udev does with udev/udevstart.
Here is the old version:
[pid 4692] execve("/etc/dev.d/default/log.dev", ["./udev", "block"], [/* 41 vars */]) = 0
this the new one:
[pid 9832] execve("/etc/dev.d/default/log.dev", ["/etc/dev.d/default/log.dev", "block"], [/* 41 vars */]) = 0
greg@kroah.com [Thu, 7 Oct 2004 07:11:04 +0000 (00:11 -0700)]
[PATCH] add support for usb interfaces to wait_for_sysfs to keep it quiet.
kay.sievers@vrfy.org [Thu, 7 Oct 2004 06:45:30 +0000 (23:45 -0700)]
[PATCH] wait_for_sysfs debug cleanup
> Sorry, I left my debug code in.
Oops, just realized it now. You've applied a older version and not the
latest. Here is a new patch to catch up.
greg@kroah.com [Thu, 7 Oct 2004 06:40:35 +0000 (23:40 -0700)]
[PATCH] enable native tdb spinlocks on i386 platforms.
also clean out some stuff in the makefile that was never getting used.
kay.sievers@vrfy.org [Thu, 7 Oct 2004 06:20:39 +0000 (23:20 -0700)]
[PATCH] fix problems using scsi_id with udevstart
when udevstart was running we didn't set the environment and the
subsystem argument for the callouts the dev.d/ scripts.
Here is a fix, that sets that with every udevstart iteration, corrects
argv[0] to be the basename() only not the whole path and adds a test
for invoking callouts without arguments.
greg@kroah.com [Thu, 7 Oct 2004 01:32:41 +0000 (18:32 -0700)]
[PATCH] delete extras/multipath-tools as per the author's request
This is now a standalone package.
kay.sievers@vrfy.org [Wed, 6 Oct 2004 07:58:04 +0000 (00:58 -0700)]
[PATCH] update volume_id
Here is an update to the latest volume_id which fixes a few bugs with
FAT volumes.
harald@redhat.com [Wed, 6 Oct 2004 07:54:08 +0000 (00:54 -0700)]
[PATCH] PATCH udev close on exec
selinux wants a clean fd set, so better close all open fds
harald@redhat.com [Wed, 6 Oct 2004 07:48:10 +0000 (00:48 -0700)]
[PATCH] PATCH some cleanups and security fixes
posted by Steve Grubb on https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=130351
harald@redhat.com [Wed, 6 Oct 2004 07:27:10 +0000 (00:27 -0700)]
[PATCH] PATCH some cleanups and security fixes
posted by Steve Grubb on https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=130351
greg@kroah.com [Wed, 6 Oct 2004 07:23:37 +0000 (00:23 -0700)]
[PATCH] be paranoid in dev_d.c
greg@kroah.com [Wed, 6 Oct 2004 06:51:24 +0000 (23:51 -0700)]
[PATCH] add USE_SELINUX to README documentation so people have a chance to see what is going on.
greg@kroah.com [Wed, 6 Oct 2004 06:49:50 +0000 (23:49 -0700)]
[PATCH] update the selinux.h file to start to look sane
and I told them to follow the proper coding style... bleah...
harald@redhat.com [Wed, 6 Oct 2004 06:39:05 +0000 (23:39 -0700)]
[PATCH] PATCH selinux for udev
Daniel Walsh's working selinux patch
harald@redhat.com [Wed, 6 Oct 2004 05:20:12 +0000 (22:20 -0700)]
[PATCH] cleanup PATCH for extras/chassis_id/Makefile
for "make install"
kpfleming@backtobasicsmgmt.com [Wed, 6 Oct 2004 05:15:16 +0000 (22:15 -0700)]
[PATCH] respect prefix= setting in built udev.conf (updated)
Here is a revised version of the patch. Again, it modifies the Makefile
to respect the prefix= setting when putting paths to
/etc/udev/{rules.s,permissions.d} into the built /etc/udev/udev.conf
file. It also changes the Makefile to create this file at "make" time,
not "make install" time. This allows for udevdir to be specified at
"make" time (thus putting the correct path into udev.conf), but not
specified at "make install" time (thus allowing the installation to
proceed without trying to use the wrong directory).
Submitted By: Kevin P. Fleming <kpfleming@linuxfromscratch.org>
Date: 2004-09-16
Initial Package Version: 032
Origin: David Jensen
Description: correct udev's Makefile and template config file
to respect the "prefix=" setting supplied when it is built; also
build etc/udev/udev.conf at "make" time, not "make install" time
greg@kroah.com [Wed, 6 Oct 2004 05:13:30 +0000 (22:13 -0700)]
[PATCH] kdetv wants to see device nodes in /dev
greg@kroah.com [Wed, 6 Oct 2004 04:56:39 +0000 (21:56 -0700)]
[PATCH] update comments in scsi-devfs.sh
kay.sievers@vrfy.org [Wed, 6 Oct 2004 04:35:39 +0000 (21:35 -0700)]
[PATCH] finally solve the bad sysfs-timing for all of us
On Tue, Sep 21, 2004 at 07:17:34PM +0200, Kay Sievers wrote:
> During the integration of HAL into the linux hotplug system, we dicover
> every week a new signaling path that fails cause of the delayed
> population of the sysfs files, which are connected by symlinks and
> appear in something like a random order in userspace.
>
> It's pretty complicated to understand the connection between all these
> files for all the different subsystems with all the exceptions, so most
> of the users simply sleep a few seconds, but that is not acceptable for
> our integration work.
>
> Here I try to get all the special knowledge about that behavior together
> and place that in a simple binary. That program _must_ run first of all
> other hotplug processsing and every later script, udev or HAL all can get
> rid of the wild guesses about the right time sysfs is ready.
>
> It will not only wait for the "dev"-file events we handle with udev, also
> for every /device-device with the corresponding bus link.
>
> It is provided as a patch against the current udev tree and a "install" will
> place the new program in the hotplug.d directory:
>
> [kay@pim ~]$ tree /etc/hotplug.d/
> /etc/hotplug.d/
> `-- default
> |-- 00-wait_for_sysfs.hotplug -> /sbin/wait_for_sysfs
> |-- 10-udev.hotplug -> /sbin/udevsend
> |-- 20-hal.hotplug -> /usr/libexec/hal.hotplug
> |-- default.hotplug
> `-- log.hotplug
>
>
> For now, it logs the result of the waiting to syslog, to catch any
> device, that needs special treatment. All newly discovered delay problems,
> device black/whitelist updates should go into that program and we may remove
> that kind of specialisation from all the other hotplug programs.
>
> Any patches, reports, testing is more than welcome.
>
> Sample debug:
> Sep 21 18:44:07 localhost kernel: usb 3-2: new full speed USB device using address 12
> Sep 21 18:44:07 localhost kernel: hub 3-2:1.0: USB hub found
> Sep 21 18:44:07 localhost kernel: hub 3-2:1.0: 2 ports detected
> Sep 21 18:44:07 localhost 00-wait_for_sysfs.hotplug: result: waiting for sysfs successful '/devices/pci0000:00/0000:00:1d.1/usb3/3-2'
> Sep 21 18:44:07 localhost 00-wait_for_sysfs.hotplug: result: waiting for sysfs successful '/devices/pci0000:00/0000:00:1d.1/usb3/3-2/3-2:1.0'
> Sep 21 18:44:08 localhost kernel: usb 3-2.1: new full speed USB device using address 13
> Sep 21 18:44:08 localhost 00-wait_for_sysfs.hotplug: result: waiting for sysfs successful '/class/usb/lp0'
> Sep 21 18:44:08 localhost kernel: drivers/usb/class/usblp.c: usblp0: USB Bidirectional printer dev 13 if 0 alt 1 proto 2 vid 0x067B pid 0x2305
> Sep 21 18:44:08 localhost 00-wait_for_sysfs.hotplug: result: waiting for sysfs successful '/devices/pci0000:00/0000:00:1d.1/usb3/3-2/3-2.1/3-2.1:1.0'
> Sep 21 18:44:08 localhost 00-wait_for_sysfs.hotplug: result: waiting for sysfs successful '/devices/pci0000:00/0000:00:1d.1/usb3/3-2/3-2.1'
> Sep 21 18:44:08 localhost udev: configured rule in '/etc/udev/rules.d/50-udev.rules' at line 29 applied, 'lp0' becomes 'usb/%k'
> Sep 21 18:44:08 localhost udev: creating device node '/udev/usb/lp0'
> Sep 21 18:44:09 localhost kernel: usb 3-2.2: new full speed USB device using address 14
> Sep 21 18:44:09 localhost kernel: pl2303 3-2.2:1.0: PL-2303 converter detected
> Sep 21 18:44:09 localhost kernel: usb 3-2.2: PL-2303 converter now attached to ttyUSB0
> Sep 21 18:44:09 localhost 00-wait_for_sysfs.hotplug: result: waiting for sysfs successful '/devices/pci0000:00/0000:00:1d.1/usb3/3-2/3-2.2'
> Sep 21 18:44:09 localhost 00-wait_for_sysfs.hotplug: result: waiting for sysfs successful '/devices/pci0000:00/0000:00:1d.1/usb3/3-2/3-2.2/3-2.2:1.0'
> Sep 21 18:44:09 localhost 00-wait_for_sysfs.hotplug: result: waiting for sysfs successful '/devices/pci0000:00/0000:00:1d.1/usb3/3-2/3-2.2/3-2.2:1.0/ttyUSB0'
> Sep 21 18:44:09 localhost 00-wait_for_sysfs.hotplug: result: waiting for sysfs successful '/class/tty/ttyUSB0'
> Sep 21 18:44:09 localhost udev: creating device node '/udev/ttyUSB0'
New version with more devices excluded from /device-link saerch and
a better maching for device names.
patmans@us.ibm.com [Wed, 6 Oct 2004 04:30:54 +0000 (21:30 -0700)]
[PATCH] update udev to include scsi_id 0.6
Here's a patch updating udev's copy of scsi_id to version 0.6.
greg@kroah.com [Wed, 6 Oct 2004 02:01:12 +0000 (19:01 -0700)]
[PATCH] fix up Makefiles to get the klibc build working properly.
Based on a patch from Kay Sievers <kay.sievers@vrfy.org>
greg@kroah.com [Wed, 6 Oct 2004 01:51:53 +0000 (18:51 -0700)]
[PATCH] oops forgot to add the new klibc/include directory
greg@kroah.com [Wed, 6 Oct 2004 01:32:12 +0000 (18:32 -0700)]
[PATCH] update klibc to version 0.181
kay.sievers@vrfy.org [Sun, 19 Sep 2004 06:22:27 +0000 (23:22 -0700)]
[PATCH] volume-id build fix and update
Let's try it another way:
We define BLKGETSIZE64 in udev-volume_id.c now, cause including <fs.h>
does also not work with klibc. This hopefully fixes your compile problem
too.
Also included is an update to udev_volume_id with the latest fixes for
volume_id. It adds a simple logging file to map the debug function, that
we can use exactly the same files in HAL and udev.
kay.sievers@vrfy.org [Thu, 16 Sep 2004 05:36:31 +0000 (22:36 -0700)]
[PATCH] switch udev's seqnum to u64
The kernel will use a u64 for the sequence number, so we want the same.
kay.sievers@vrfy.org [Wed, 15 Sep 2004 04:44:55 +0000 (21:44 -0700)]
[PATCH] add enum tests
On Fri, Sep 10, 2004 at 01:09:07PM -0700, Greg KH wrote:
> On Tue, Sep 07, 2004 at 01:19:34PM +0200, David Zeuthen wrote:
> >
> > KERNEL="sr*", NAME="%k", SYMLINK="cdrom%e"
> > KERNEL="scd*", NAME="%k", SYMLINK="cdrom%e"
> > KERNEL="pcd*", NAME="%k", SYMLINK="cdrom%e"
> > KERNEL="hd[a-z]", PROGRAM="/bin/cat /proc/ide/%k/media", RESULT="cdrom", NAME="\%k", SYMLINK="cdrom%e"
> > KERNEL="fd[0-9]", NAME="%k", SYMLINK="floppy%e"
> > KERNEL="hd[a-z]", PROGRAM="/bin/cat /proc/ide/%k/media", RESULT="floppy", NAME=\"%k", SYMLINK="floppy%e"
> >
> > New patch is attached.
>
> Nice, I've applied this.
>
> How about sending a patch for the test/udev-test.pl script that adds a
> test for this new paramater, so we make sure to not break it in the
> future.
Here are the tests for the enumeration character %e. I've added a option
string to be able to do a whole sequence of tests without node removal,
so we can skip the "remove" event and get an increasing number to append
to the name. After the sequence test the whole directory is cleaned for
the next tests.
kay.sievers@vrfy.org [Wed, 15 Sep 2004 00:45:48 +0000 (17:45 -0700)]
[PATCH] fix udev segfaults with bad permissions file
On Tue, Sep 14, 2004 at 02:53:12PM +0200, Loleslaw wrote:
> Hi,
> Since I started using udev-031 on my gentoo udevstart would just segfault
> (udev-030 worked). As it turned out I had a file in /etc/udev/permissions.d
> with a single space in one line. I've cleaned the file and it works all
> right, but I thought you could be interested.
> I've traced it to function namedev_init_permissions in namedev_parse.c
> I don't know C well enough to suggest a patch.
Yeah, thanks for pointing that out. It only happens if the file ends with
whitespace-only lines. Here is a fix and a test for udev-test.pl to
cover that case.
greg@kroah.com [Tue, 14 Sep 2004 13:55:08 +0000 (06:55 -0700)]
[PATCH] 032 release
harald@redhat.com [Tue, 14 Sep 2004 13:50:38 +0000 (06:50 -0700)]
[PATCH] udev parse bug
There is a bug parsing PROGRAMs after apostrophes. Try PROGRAM="/bin/echo 'test test".
kay.sievers@vrfy.org [Tue, 14 Sep 2004 13:50:33 +0000 (06:50 -0700)]
[PATCH] handle only block and class devices
Fix a stupid logic bug, I introduced with the udev.c simplification. We
want to look at class and block devices only.
kay.sievers@vrfy.org [Tue, 14 Sep 2004 13:50:28 +0000 (06:50 -0700)]
[PATCH] fix udevstart badly broken in udev 031
On Mon, 2004-09-13 at 01:56 +0200, Marco d'Itri wrote:
> Starting from udev 031, the %-arguments passed to PROGRAMs are not
> correct when the new udevstart code is being used.
>
> KERNEL="event[0-9]*", NAME="input/%k", PROGRAM="/etc/udev/inputdev.sh %k %n %M %m", RESULT="inputdev", MODE="0664", GROUP="video"
>
> generates this log (just echo $*):
>
> event0 0 13 64
> event0 0 13 64
> event0 0 13 64
>
> while the correct log (generated using the old shell script instead of
> udevstart) would be:
>
> event0 0 13 64
> event1 1 13 65
> event2 2 13 66
Yes, I can simulate this, please try the attached patch. I expect, that
it fixes it, cause we better not mangle the parsed config while matching
the rules.
greg@kroah.com [Sat, 11 Sep 2004 05:09:58 +0000 (22:09 -0700)]
[PATCH] 031 release
greg@kroah.com [Sat, 11 Sep 2004 04:58:59 +0000 (21:58 -0700)]
[PATCH] add symlink for video rule.
greg@kroah.com [Sat, 11 Sep 2004 04:44:15 +0000 (21:44 -0700)]
[PATCH] add a "first" list to udevstart and make it contain the class/mem/ devices
Seems some programs really want /dev/null to work properly :)
greg@kroah.com [Sat, 11 Sep 2004 04:13:18 +0000 (21:13 -0700)]
[PATCH] fix compiler warning in udevtest.c
kay.sievers@vrfy.org [Sat, 11 Sep 2004 04:09:25 +0000 (21:09 -0700)]
[PATCH] Fix naming ethernet devices in udevstart
On Tue, Sep 07, 2004 at 12:46:43PM +0200, Kay Sievers wrote:
> On Mon, 2004-09-06 at 20:18 -0700, Tom Rini wrote:
> > I noticed somewhat recently that my enet devices weren't being renamed
> > on boot anymore. I don't quite know when this got broken (or rather, if
> > it was supposed to be working. I swear it worked for me once..), but
> > the following seems to do it.
>
> I think it never worked in the udevstart case. It worked only with the
> hotplug-event-udev, I expect.
>
> > In udev_scan_class(), look for not just
> > %s/%s/dev (which everything with a dev node has), but %s/%s/dev* (both
> > of my enet devices, sis900 & 3c59x only have device) and if that
> > exists, pass this along to udev.
>
> Yeah, network devices don't have a devnode and therefore no "dev", but
> they are all in /sys/class/net/. We may just test if we are there
> instead of the "device" match.
How about something like this. It adds all the net devices without
looking at the attributes and keeps the remaining logic like it is.
It also removes certain levels of indirection and much simplifies the
udevstart process. We surely don't need to open and close the udevdb
for every node while iterating over the list. (We are about 5% faster on
my box)
It's not well tested, so it would be nice if someone can have a look
at it, before a broken udevstart renders any system unbootable.
david@fubar.dk [Sat, 11 Sep 2004 04:04:13 +0000 (21:04 -0700)]
[PATCH] compatibility symlinks for udev
On Mon, 2004-09-06 at 17:45 +0200, Kay Sievers wrote:
> On Mon, 2004-09-06 at 16:46 +0200, David Zeuthen wrote:
>
> Nice, I like it. It's a easy way to group device nodes of the same type,
> but coming from different kernel subsystems.
>
That's a good way of putting it, yeah.
> > Here's a patch against udev-030 that can help create compatibility
> > symlinks like /dev/cdrom, /dev/cdrom1 etc. The patch introduces a new
> > substitution type %C (for Compatibility) that can be used as follows
>
> I suggest using %e for enumeration here, cause "compatibility" can
> easily be misunderstood.
>
Good point, I've changed that.
> And we need a few lines added to the man page at udev.8.in :)
>
Done. I've also added an example.
Also, Kay pointed out offlist that the rules can be written to not
require a shell script; this actually works
KERNEL="sr*", NAME="%k", SYMLINK="cdrom%e"
KERNEL="scd*", NAME="%k", SYMLINK="cdrom%e"
KERNEL="pcd*", NAME="%k", SYMLINK="cdrom%e"
KERNEL="hd[a-z]", PROGRAM="/bin/cat /proc/ide/%k/media", RESULT="cdrom", NAME="\%k", SYMLINK="cdrom%e"
KERNEL="fd[0-9]", NAME="%k", SYMLINK="floppy%e"
KERNEL="hd[a-z]", PROGRAM="/bin/cat /proc/ide/%k/media", RESULT="floppy", NAME=\"%k", SYMLINK="floppy%e"
New patch is attached.
David
arun@codemovers.org [Sat, 11 Sep 2004 03:54:04 +0000 (20:54 -0700)]
[PATCH] udev - read long lines from config files overflow fix
Hi Kay,
On 23:12 Sat 04 Sep , Kay Sievers wrote:
> Cool, a real bug :)
> Thanks, for the patch. I think it would be better to skip lenghth exceeding
> lines instead of cutting it and continue. While looking at it I restructured
> the buffer reading logic a bit and fixed another stupid bug.
Thanks for the cleanup.
You may have overlooked the fix for udev_config.c(parsing udev.conf) in
your patch. So, I've adapted the fixes you applied to namedev_parse.c
to this file also.
Also, while 'eating' the whitespace the 'count' doesn't get decremented.
This leads strncpy to copy the number of whitespace minus 1 characters
from the next line. Minus 1 because it copies '\n' from the current
line.
while (isspace(bufline[0])) {
bufline++;
+ count--;
}
.
.
.
strncpy(line, bufline, count);
Included patch(against udev-030) contains the above fixes as well as
your fixes.
Signed-off-by: Arun Bhanu <arun@codemovers.org>
olh@suse.de [Tue, 7 Sep 2004 07:55:07 +0000 (00:55 -0700)]
[PATCH] udevsend depends on udev_lib.o
make -j doesnt work with current udev.
kay.sievers@vrfy.org [Sun, 5 Sep 2004 16:05:36 +0000 (18:05 +0200)]
[PATCH] update udev_volume_id
Here is an update for the volume_id callout to catch up to the latest
and greatest:
o It is able to skip the label reading of linux raid members, which are
otherwise recognized as a normal filesystem.
o It reads FAT labels stored in the directory instead of the
superblock (Windows only writes in the directory).
o The NTFS uuid is the right one now.
o It reads all the Apple HFS(+) formats with the labels.
o UFS volumes are recognized but no labels are extracted.
o We use CFLAGS+=-D_FILE_OFFSET_BITS=64 instead of lsee64() which may fix
a bug mentioned on the klibc mailing list.
A lot of other new features are only used in HAL and not needed in this
simple callout. But if someone stumbles over it and want's to send a patch
for some exotic formats, we better keep it up to date :)
kay.sievers@vrfy.org [Sun, 5 Sep 2004 16:05:32 +0000 (18:05 +0200)]
[PATCH] let /sbin/hotplug execute udev earlier
We ran into problems with all the /etc/hotplug.d/ scripts that sleep for
the sysfs files or for other reasons. Anyway, it takes much too much time
before udev is executed.
HAL has its own notifier in /etc/hotplug.d/ and also waits for the
dev.d/events with the same SEQNUM. Sometimes it take 25 seconds between
these two events, cause the other scripts are sleeping too much :)
Attached is a patch that installs the udevsend symlink as
10-udev.hotplug instead of udev.hotplug, to be executed earlier.
[kay@pim udev.kay]$ tree /etc/hotplug.d/
/etc/hotplug.d/
`-- default
|-- 10-udev.hotplug -> /sbin/udevsend
|-- 20-hal.hotplug -> /usr/libexec/hal.hotplug
`-- default.hotplug
kay.sievers@vrfy.org [Sun, 5 Sep 2004 16:05:29 +0000 (18:05 +0200)]
[PATCH] pass SEQNUM trough udevd
here we change udevd to pass the SEQNUM from the hotplug environment
to udev and the dev.d/ scripts. We need this for HAL to match the
hotplug event with the dev.d/ events.
It also changes the type from int to long to match the kernel.
greg@kroah.com [Sun, 5 Sep 2004 15:56:08 +0000 (17:56 +0200)]
[PATCH] Fix old-style pty breakage in rules file for tty device.
Thanks to Martin Schlemmer <azarah@nosferatu.za.org> for the fix.
greg@kroah.com [Sun, 5 Sep 2004 15:53:11 +0000 (17:53 +0200)]
[PATCH] add rules for i386 cpu devices.
greg@kroah.com [Sun, 5 Sep 2004 15:52:51 +0000 (17:52 +0200)]
[PATCH] add permission for legotower usb devices.
kay.sievers@vrfy.org [Wed, 11 Aug 2004 08:03:06 +0000 (01:03 -0700)]
[PATCH] fix manpages based on esr's spambot
On Mon, Jul 12, 2004 at 11:14:28AM -0400, esr@thyrsus.com wrote:
> This is automatically generated email about problems in a man page for which
> you appear to be responsible. If you are not the right person or list, tell
> me and I will attempt to correct my database.
>
> See http://catb.org/~esr/doclifter/problems.html for details on how and
> why these patches were generated. Feel free to email me with any questions.
>
> Note: This patch does not change the mod date of the manual page. You
> may wish to do that by hand.
>
> Problems with udevd.8:
>
> 1. There are multiple name lines. This makes it impossible to translate
> the page to DocBook. It may also confuse some implementations
> of man -k.
>
> --- udevd.8-orig 2004-07-10 06:35:12.
032545856 -0400
> +++ udevd.8 2004-07-10 06:36:19.
301319448 -0400
> @@ -1,8 +1,6 @@
> .TH UDEVD 8 "February 2004" "" "Linux Administrator's Manual"
> .SH NAME
> -udevd \- udev event serializer daemon
> -.br
> -udevsend \- sends the event to udevd
> +udevd, udevdsend \- udev event serializer daemon and udev event sender
> .SH SYNOPSIS
> --
> Eric S. Raymond
>
Thanks Eric, udevsend.8 is only a symlink to udevd.8, so I attached a
stripped down patch to this mail.
tao@kernel.org [Wed, 11 Aug 2004 08:03:03 +0000 (01:03 -0700)]
[PATCH] Minor POSIX-fixes for udev
The attached patch contains a few patches against udev, to remove
use of various XSI:isms and bash:isms, and to change two scripts form
/bin/bash to /bin/sh. None of the bash-scripts in test/ uses any
bash-specific functions as far as I know, but I didn't touch them since
they aren't used runtime.
Rationale:
* Both of the /bin/bash-scripts are totally free from bashisms, hence they
don't need to be /bin/bash; using /bin/sh instead helps (mainly)
embedded-people
* local and source are bash:isms (well, they exist in several other
shells as well, but they aren't part of POSIX or any of its extensions)
* -a in tests is an XSI-extension, not part of strict POSIX, and is
easily replaced by &&
| http://www.opengroup.org/onlinepubs/
009695399/utilities/test.html
* Use of fgrep is deprecated in POSIX in favour of grep -F (though fgrep
will remain in use for a long time...)
| http://www.opengroup.org/onlinepubs/
009695399/utilities/grep.html
The fgrep-change isn't really necessary, since fgrep can always be
implemented as a shell-script, but the rest of the changes would really
be appreciated.
trini@kernel.crashing.org [Wed, 11 Aug 2004 08:02:59 +0000 (01:02 -0700)]
[PATCH] fix UDEV_NO_SLEEP
Move setting UDEV_NO_SLEEP into main(). I thought about moving
udev_init_config() around, but it still must be invoked in both udev and
udevstart cases, and before udev_hotplug() is called. An alternative
would be to have main() do:
if (is_udevstart) {
... current ...
} else {
udev_init_config();
return udev_hotplug();
}
And move setting UDEV_NO_SLEEP into udev_start(). I can redo it that
way, if you prefer.
Signed-off-by: Tom Rini <trini@kernel.crashing.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
trini@kernel.crashing.org [Wed, 11 Aug 2004 08:02:56 +0000 (01:02 -0700)]
[PATCH] clean up start_udev a bit
First, update extras/start_udev. udevstart always internally set
UDEV_NO_SLEEP as well as setting the ACTION variable, so that only needs
to be done in the run_udev script case.
Signed-off-by: Tom Rini <trini@kernel.crashing.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
azarah@gentoo.org [Wed, 11 Aug 2004 08:02:54 +0000 (01:02 -0700)]
[PATCH] add microcode rule to permissions.gentoo file
Add microcode rule, remove duplicate rtc and psaux rules,
and order alphabetically.
trini@kernel.crashing.org [Tue, 10 Aug 2004 07:50:21 +0000 (00:50 -0700)]
[PATCH] Make udev/udevstart be one binary
Hi,
The following patch makes udev/udevstart be a common binary. First,
doing this grows udev by a total of 1.8kB (ppc32, stripped) whereas
udevstart by itself is 6.4kB. I know you mentioned being able to
replace udevstart with a script, but at 1.8kB I don't think it'll be
easy to beat this with size there. Next, the following are by-eye
timings of before, after, and with devfs on a slow, but still usable
embedded platform (config stripped down to more-or-less bare for
ramdisk):
-- Embedded Planet RPX LITE, 64Mhz MPC 823e --
devfs : 15.333s, 15.253s, 14.988s (15.191s avg)
udev-pristine : 18.675s, 18.079s, 18.418s (18.390s avg)
udev-multi : 14.587s, 14.747s, 14.868s (14.734s avg)
The patch ends up being rather large to add this, as in doing so I ended
up making all refs (that I hit..) to devpath/subsystem be marked as
'const'.
Signed-off-by: Tom Rini <trini@kernel.crashing.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>