chiark / gitweb /
Re-send [StGit BUG/PATCH] config.py: fix unset
authorChris Packham <judge.packham@gmail.com>
Mon, 10 Aug 2009 20:50:45 +0000 (08:50 +1200)
committerCatalin Marinas <catalin.marinas@arm.com>
Thu, 13 Aug 2009 22:23:16 +0000 (23:23 +0100)
Missing invocation of .run() so config.unset('blah') didn't do anything.
Consequently the fact that the next line set the value to 'None' instead of a
list with 1 element i.e. '[None]' was not noticed.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
stgit/config.py

index 4a6cb3bbe04708642c6152b8642822c75e48dedd..6f84b10d80b468fe537ddcf19026a98e5e4e8210 100644 (file)
@@ -94,8 +94,8 @@ class GitConfig:
         self.__cache[name] = value
 
     def unset(self, name):
-        Run('git', 'config', '--unset', name)
-        self.__cache[name] = None
+        Run('git', 'config', '--unset', name).run()
+        self.__cache[name] = [None]
 
     def sections_matching(self, regexp):
         """Takes a regexp with a single group, matches it against all