Leave a comment about iffy icon sensivity; it's definitely setting the

right thing so I think this is a GTK+ bug.

diff --git a/disobedience/control.c b/disobedience/control.c
index 0b22b888966cb016403191042394c28e2b93dcd0..c41673ad97e3a6ed0987d16e9ea9a9b6bf7499ca 100644 (file)
--- a/disobedience/control.c
+++ b/disobedience/control.c
@@ -384,6 +384,11 @@ static void icon_changed(const char attribute((unused)) *event,
     gtk_container_add(GTK_CONTAINER(icon->button), newchild);
     gtk_widget_show(newchild);
   }
     gtk_container_add(GTK_CONTAINER(icon->button), newchild);
     gtk_widget_show(newchild);
   }

+  /* If you disable play or random play NOT via the icon (for instance, via the
+   * edit menu or via a completely separate command line invocation) then the
+   * icon shows up as insensitive.  Hover the mouse over it and the corrcet
+   * state is immediately displayed.  sensitive and GTK_WIDGET_SENSITIVE show
+   * it to be in the correct state, so I think this is may be a GTK+ bug. */

   if(icon->tip_on)
     gtk_tooltips_set_tip(tips, icon->button,
                            on ? icon->tip_on : icon->tip_off, "");
   if(icon->tip_on)
     gtk_tooltips_set_tip(tips, icon->button,
                            on ? icon->tip_on : icon->tip_off, "");

diff --git a/disobedience/queue-generic.c b/disobedience/queue-generic.c
index 5759915c62412c25569ef978b7f4fe117ebaa6af..51969957c1b6c4bf91d802211eb0a2794e52adc1 100644 (file)
--- a/disobedience/queue-generic.c
+++ b/disobedience/queue-generic.c
@@ -37,7 +37,6 @@
  * status to everything else found in that list.
  *
  * To do:
  * status to everything else found in that list.
  *
  * To do:

- * - random play icon sensitivity is wrong (onl) if changed from edit menu

  * - drag and drop queue rearrangement
  * - display playing row in a different color?
  */
  * - drag and drop queue rearrangement
  * - display playing row in a different color?
  */