chiark / gitweb /
fairphone-case: fix CaseAperture (nfc)
authorIan Jackson <ijackson@chiark.greenend.org.uk>
Sun, 21 Jan 2018 16:47:53 +0000 (16:47 +0000)
committerIan Jackson <ijackson@chiark.greenend.org.uk>
Sun, 21 Jan 2018 16:47:53 +0000 (16:47 +0000)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
fairphone-case.scad

index a422453..238abba 100644 (file)
@@ -266,13 +266,13 @@ module AroundEdges(fill_zstart, fill_th, fill_downwards=0){
               [phone_width, -phone_height] + [-1,+1] * phone_cnr_rad);
 }
 
               [phone_width, -phone_height] + [-1,+1] * phone_cnr_rad);
 }
 
-module CaseAperture(pos, dia) { // pass $fn too
+module CaseAperture(pos, dia, $fn) {
   theta = 180/$fn;
   translate([ pos[0] + bumper[0],
              -epp2i[0],
              -pos[1] ])
     rotate([-90, theta, 0])
   theta = 180/$fn;
   translate([ pos[0] + bumper[0],
              -epp2i[0],
              -pos[1] ])
     rotate([-90, theta, 0])
-    cylinder(r = jack_dia/2 / cos(theta),
+    cylinder(r = dia/2 / cos(theta),
             h = 60);
 }
 
             h = 60);
 }
 
@@ -388,7 +388,7 @@ module Case(){ ////toplevel
     }
 
     // apertures along top edge
     }
 
     // apertures along top edge
-    CaseAperture(jack_pos, jack_dia, $fn=8);
+    CaseAperture(jack_pos, jack_dia, 8);
   }
 }
 
   }
 }