chiark / gitweb /
Pass default date to KnownApks.recordapk()
authorDmitriy Bogdanov <d@di72nn.com>
Sun, 26 Jun 2016 15:18:50 +0000 (19:18 +0400)
committerDmitriy Bogdanov <d@di72nn.com>
Sun, 26 Jun 2016 15:18:50 +0000 (19:18 +0400)
... if --use-date-from-apks option is used

fdroidserver/common.py
fdroidserver/update.py

index f27177fe1f4ad44d28a3add0f8d750c3c36398f6..88477b1836ffcacec38a3b53b442ad257c9e77ef 100644 (file)
@@ -1570,9 +1570,11 @@ class KnownApks:
 
     # Record an apk (if it's new, otherwise does nothing)
     # Returns the date it was added.
-    def recordapk(self, apk, app):
+    def recordapk(self, apk, app, default_date=None):
         if apk not in self.apks:
-            self.apks[apk] = (app, time.gmtime(time.time()))
+            if default_date is None:
+                default_date = time.gmtime(time.time())
+            self.apks[apk] = (app, default_date)
             self.changed = True
         _, added = self.apks[apk]
         return added
index 7cd18f415af28361d433cf02a8709dbc61b9baad..b35f9287c4fcd1c0839adc32d646e30f8fb031e1 100644 (file)
@@ -698,13 +698,14 @@ def scan_apks(apps, apkcache, repodir, knownapks, use_date_from_apk=False):
                 shutil.copyfile(baseline,
                                 os.path.join(get_icon_dir(repodir, '0'), iconfilename))
 
+            if use_date_from_apk and manifest.date_time[1] != 0:
+                default_date_param = datetime(*manifest.date_time).utctimetuple()
+            else:
+                default_date_param = None
+
             # Record in known apks, getting the added date at the same time..
-            added = knownapks.recordapk(apk['apkname'], apk['id'])
+            added = knownapks.recordapk(apk['apkname'], apk['id'], default_date=default_date_param)
             if added:
-                if use_date_from_apk and manifest.date_time[1] != 0:
-                    added = datetime(*manifest.date_time).timetuple()
-                    logging.debug("Using date from APK")
-
                 apk['added'] = added
 
             apkcache[apkfilename] = apk