chiark / gitweb /
[PATCH] udev-test.pl - tweaks
authorkay.sievers@vrfy.org <kay.sievers@vrfy.org>
Mon, 24 Nov 2003 13:44:01 +0000 (05:44 -0800)
committerGreg KH <gregkh@suse.de>
Wed, 27 Apr 2005 04:13:02 +0000 (21:13 -0700)
I found two missing characters and optimized $PWD.

test/udev-test.pl

index 02f8ff6..e4a4ddc 100644 (file)
@@ -21,9 +21,7 @@
 use warnings;
 use strict;
 
-my $PWD = `pwd`;
-chomp($PWD);
-
+my $PWD = $ENV{PWD};
 my $sysfs     = "sys/";
 my $udev_bin  = "../udev";
 my $udev_root = "udev-root/"; # !!! directory will be removed !!!
@@ -80,7 +78,7 @@ TOPOLOGY, BUS="scsi", PLACE="0:0:0:0", NAME="Major:%M:minor:%m:kernelnumber:%n:b
 EOF
        },
        {
-               desc     => "callout result subtitution, only last should match",
+               desc     => "callout result substitution, only last should match",
                subsys   => "block",
                devpath  => "block/sda/sda3",
                expected => "special-device-3" ,
@@ -93,7 +91,7 @@ CALLOUT, BUS="scsi", PROGRAM="/bin/echo -n special-device", ID="special-*", NAME
 EOF
        },
        {
-               desc     => "callout program subtitution",
+               desc     => "callout program substitution",
                subsys   => "block",
                devpath  => "block/sda/sda3",
                expected => "test-0:0:0:0" ,
@@ -151,7 +149,6 @@ foreach my $config (@tests) {
                system("tree $udev_root");
                print "\n";
                $error++;
-#              next;
        }
 
        udev("remove", $config->{subsys}, $config->{devpath}, \$config->{conf});