chiark
/
gitweb
/
~ianmdlvl
/
elogind.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(from parent 1:
2c2ecbe
)
sd-device: don't use alloca() within loops
author
Tom Gundersen
<teg@jklm.no>
Sun, 5 Apr 2015 10:17:29 +0000
(12:17 +0200)
committer
Sven Eden
<yamakuzure@gmx.net>
Tue, 14 Mar 2017 06:50:10 +0000
(07:50 +0100)
I shall not use alloca() within loops
I shall not use alloca() within loops
I shall not use alloca() within loops
I shall not use alloca() within loops
...
src/libelogind/sd-device/device-private.c
patch
|
blob
|
history
diff --git
a/src/libelogind/sd-device/device-private.c
b/src/libelogind/sd-device/device-private.c
index 86d760cddf0f788e4c6ac44ea1778c46f3feb15f..9788df769cfbf249e730da89838a26092974523b 100644
(file)
--- a/
src/libelogind/sd-device/device-private.c
+++ b/
src/libelogind/sd-device/device-private.c
@@
-423,9
+423,10
@@
static int device_amend(sd_device *device, const char *key, const char *value) {
size_t l;
FOREACH_WORD(word, l, value, state) {
- char
*devlink
;
+ char
devlink[l + 1]
;
- devlink = strndupa(word, l);
+ strncpy(devlink, word, l);
+ devlink[l] = '\0';
r = device_add_devlink(device, devlink);
if (r < 0)
@@
-436,9
+437,10
@@
static int device_amend(sd_device *device, const char *key, const char *value) {
size_t l;
FOREACH_WORD_SEPARATOR(word, l, value, ":", state) {
- char
*tag
;
+ char
tag[l + 1]
;
- tag = strndupa(word, l);
+ (void)strncpy(tag, word, l);
+ tag[l] = '\0';
r = device_add_tag(device, tag);
if (r < 0)