chiark / gitweb /
bus: use memcpy() rather than unbounded strcpy()
authorLennart Poettering <lennart@poettering.net>
Mon, 23 Dec 2013 01:08:05 +0000 (02:08 +0100)
committerLennart Poettering <lennart@poettering.net>
Mon, 23 Dec 2013 03:20:55 +0000 (04:20 +0100)
src/libsystemd-bus/bus-control.c

index f08d78a..2acd20b 100644 (file)
@@ -803,7 +803,7 @@ static int add_name_change_match(sd_bus *bus,
                 item->name_change.new.id = new_owner_id;
 
                 if (name)
-                        strcpy(item->name_change.name, name);
+                        memcpy(item->name_change.name, name, l);
 
                 /* If the old name is unset or empty, then
                  * this can match against added names */
@@ -854,7 +854,9 @@ static int add_name_change_match(sd_bus *bus,
                 m->cookie = cookie;
 
                 item = m->items;
-                item->size = offsetof(struct kdbus_item, id_change) + sizeof(struct kdbus_notify_id_change);
+                item->size =
+                        offsetof(struct kdbus_item, id_change) +
+                        sizeof(struct kdbus_notify_id_change);
                 item->id_change.id = name_id;
 
                 /* If the old name is unset or empty, then this can