sd-daemon: fix cppcheck warnings

Found with 'cppcheck --enable=all --inconclusive --std=posix' while
working with util-linux, which has a copy of this file.

[misc-utils/sd-daemon.c:363]: (style) Checking if unsigned variable \
'length' is less than zero.
[misc-utils/sd-daemon.c:366]: (style) Checking if unsigned variable \
'length' is less than zero.

References: http://www.spinics.net/lists/util-linux-ng/msg07031.html

diff --git a/src/libsystemd-daemon/sd-daemon.c b/src/libsystemd-daemon/sd-daemon.c
index 4801d2cd18ff31fffdeee9fc0ed1d6a1bf8164c0..80aadf7adfc7c6da21acb7d3bd64cb6f74b6e0cc 100644 (file)
--- a/src/libsystemd-daemon/sd-daemon.c
+++ b/src/libsystemd-daemon/sd-daemon.c
@@ -364,10 +364,10 @@ _sd_export_ int sd_is_socket_unix(int fd, int type, int listening, const char *p
                 return 0;
 
         if (path) {
                 return 0;
 
         if (path) {

-                if (length <= 0)
+                if (length == 0)

                         length = strlen(path);
 
                         length = strlen(path);
 

-                if (length <= 0)
+                if (length == 0)

                         /* Unnamed socket */
                         return l == offsetof(struct sockaddr_un, sun_path);
 
                         /* Unnamed socket */
                         return l == offsetof(struct sockaddr_un, sun_path);