chiark / gitweb /
rules_generator: do not create rules with insufficient matches
authorKay Sievers <kay.sievers@vrfy.org>
Tue, 20 Nov 2007 17:18:03 +0000 (18:18 +0100)
committerKay Sievers <kay.sievers@vrfy.org>
Tue, 20 Nov 2007 17:18:03 +0000 (18:18 +0100)
Thanks to Alexander E. Patrakov for pointing out that we create
invalid rules.

We still need a proper fix for devices we skip creating rules
(locally administered MAC), but want to swap names with interface
names we created rules for.

extras/rule_generator/75-persistent-net-generator.rules

index 726bf27..2aa3076 100644 (file)
@@ -44,6 +44,9 @@ SUBSYSTEMS=="ieee1394", ENV{COMMENT}="Firewire device $attr{host_id})"
 # S/390 uses id matches only, do not use MAC address match
 SUBSYSTEMS=="ccwgroup", ENV{COMMENT}="S/390 $driver device at $id", ENV{MATCHID}="$id", ENV{MATCHDRV}="$driver", ENV{MATCHADDR}=""
 
+# see if we got enough data to create a rule
+ENV{MATCHADDR}=="", ENV{MATCHID}=="", ENV{INTERFACE_NAME}=="", GOTO="persistent_net_generator_end"
+
 # default comment
 ENV{COMMENT}=="", ENV{COMMENT}="$env{SUBSYSTEM} device"