mount: clarify that we really need to replace the utab inotify code with the native...

diff --git a/TODO b/TODO
index a09451d77719b52ad544465842477cf7450ad74e..23fb68c67de753386417ad2161fdaea68d95e3eb 100644 (file)
--- a/TODO
+++ b/TODO
@@ -1,7 +1,5 @@
 Preparations for 218:
 
-* port libmount hookup to use API's own inotify interface
-
 * cgroup delegation issues
 
 * should networkd's [BridgePort] section really be called like that?
@@ -43,6 +41,8 @@ External:
 
 Features:
 
+* port libmount hookup to use API's own inotify interface, as soon as that is table in libmount
+
 * bash completion for busctl, to make it truly useful
 
 * journald: broken file systems are real (btrfs), we need to handle

diff --git a/src/core/mount.c b/src/core/mount.c
index 66de85b5789701825994d9736095a38024f582ed..6b415b44e98c71e0fb3f35e90df5089a8f989f3f 100644 (file)
--- a/src/core/mount.c
+++ b/src/core/mount.c
@@ -1665,6 +1665,10 @@ static int mount_dispatch_io(sd_event_source *source, int fd, uint32_t revents,
         if (fd == m->utab_inotify_fd) {
                 bool rescan = false;
 
+                /* FIXME: We *really* need to replace this with
+                 * libmount's own API for this, we should not hardcode
+                 * internal behaviour of libmount here. */
+
                 for (;;) {
                         uint8_t buffer[INOTIFY_EVENT_MAX] _alignas_(struct inotify_event);
                         struct inotify_event *e;