logind,machined,run: properly invoke StartTransientUnit() bus call

diff --git a/src/libsystemd-bus/bus-objects.c b/src/libsystemd-bus/bus-objects.c
index 8413023d6f979a0bb0f0c27b3676e898cbfd050b..06be5ed7d8ff9ea935fe22b3164f4d9a9621d51c 100644 (file)
--- a/src/libsystemd-bus/bus-objects.c
+++ b/src/libsystemd-bus/bus-objects.c
@@ -292,14 +292,11 @@ static int method_callbacks_run(
                 return -EINVAL;
 
         if (!streq(strempty(c->vtable->x.method.signature), signature)) {
-                r = sd_bus_reply_method_errorf(m,
-                                               SD_BUS_ERROR_INVALID_ARGS,
-                                               "Invalid arguments '%s' to call %s:%s, expecting '%s'.",
-                                               signature, c->interface, c->member, strempty(c->vtable->x.method.signature));
-                if (r < 0)
-                        return r;
-
-                return 1;
+                return sd_bus_reply_method_errorf(
+                                m,
+                                SD_BUS_ERROR_INVALID_ARGS,
+                                "Invalid arguments '%s' to call %s.%s(), expecting '%s'.",
+                                signature, c->interface, c->member, strempty(c->vtable->x.method.signature));
         }
 
         if (c->vtable->x.method.handler) {

diff --git a/src/login/logind-dbus.c b/src/login/logind-dbus.c
index b1c2ef19b13da67d6f999857572625a219666d3e..a52b00181d5f34a440010061bf34af1514c3d7ac 100644 (file)
--- a/src/login/logind-dbus.c
+++ b/src/login/logind-dbus.c
@@ -2216,6 +2216,10 @@ int manager_start_scope(
         if (r < 0)
                 return r;
 
+        r = sd_bus_message_append(m, "a(sa(sv))", 0);
+        if (r < 0)
+                return r;
+
         r = sd_bus_call(manager->bus, m, 0, error, &reply);
         if (r < 0)
                 return r;

diff --git a/src/machine/machined-dbus.c b/src/machine/machined-dbus.c
index eda582ae830acf84e13ad0488b4cbfa7fed1b067..34cd61d667edfc357060cbbe3901c1e11dfd9e41 100644 (file)
--- a/src/machine/machined-dbus.c
+++ b/src/machine/machined-dbus.c
@@ -527,6 +527,10 @@ int manager_start_scope(
         if (r < 0)
                 return r;
 
+        r = sd_bus_message_append(m, "a(sa(sv))", 0);
+        if (r < 0)
+                return r;
+
         r = sd_bus_call(manager->bus, m, 0, error, &reply);
         if (r < 0)
                 return r;

diff --git a/src/run/run.c b/src/run/run.c
index 539db6f4942776d205fea291b04014d18511972e..2e0cd1a6d228792064ff6b2279cd1f904a9f1e09 100644 (file)
--- a/src/run/run.c
+++ b/src/run/run.c
@@ -237,6 +237,10 @@ static int message_start_transient_unit_send(sd_bus *bus, sd_bus_message *m, sd_
         if (r < 0)
                 return r;
 
+        r = sd_bus_message_append(m, "a(sa(sv))", 0);
+        if (r < 0)
+                return r;
+
         return sd_bus_call(bus, m, 0, error, reply);
 }