chiark / gitweb /
[PATCH] small cleanup udev-remove.c
authorkay.sievers@vrfy.org <kay.sievers@vrfy.org>
Tue, 23 Dec 2003 06:47:58 +0000 (22:47 -0800)
committerGreg KH <gregkh@suse.de>
Wed, 27 Apr 2005 04:13:10 +0000 (21:13 -0700)
Here is a small cleanup. It replaces the malloc in udev-remove.c
with a struct, like we do in udev-add.c

udev-remove.c

index 6d7e2ad22a9c6d8af3becb485709a05e8d1ab202..c5de6c823fc8d938a2eb35e55c4da22126b588ac 100644 (file)
@@ -118,30 +118,26 @@ static int delete_node(struct udevice *dev)
  */
 int udev_remove_device(char *path, char *subsystem)
 {
-       struct udevice *dev;
+       struct udevice dev;
        char *temp;
        int retval;
 
-       dev = malloc(sizeof(*dev));
-       if (dev == NULL)
-               return -ENOMEM;
-       memset(dev, 0, sizeof(*dev));
+       memset(&dev, 0, sizeof(dev));
 
-       retval = udevdb_get_dev(path, dev);
+       retval = udevdb_get_dev(path, &dev);
        if (retval) {
                dbg("'%s' not found in database, falling back on default name", path);
                temp = strrchr(path, '/');
                if (temp == NULL)
                        return -ENODEV;
-               strncpy(dev->name, &temp[1], sizeof(dev->name));
+               strncpy(dev.name, &temp[1], sizeof(dev.name));
        }
 
-       dbg("name is '%s'", dev->name);
+       dbg("name is '%s'", dev.name);
        udevdb_delete_dev(path);
 
-       sysbus_send_remove(dev->name, path);
+       sysbus_send_remove(dev.name, path);
 
-       retval = delete_node(dev);
-       free(dev);
+       retval = delete_node(&dev);
        return retval;
 }