networkd: add an assert

This error should never happen, so replace the check with an assert. The check
was anyway broken due to an uninitialized return value.

Reported by Thomas Hindoe Paaboel Andersen <phomes@gmail.com>.

diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c
index 684e1e5d3d9ca9fc01d464c32cec9960ab7abb39..31b4befd72abfc0de5d2e8ae3b0a72e9c3cb1b8d 100644 (file)
--- a/src/network/networkd-link.c
+++ b/src/network/networkd-link.c
@@ -1518,8 +1518,7 @@ int link_save(Link *link) {
         assert(link->state_file);
 
         state = link_state_to_string(link->state);
-        if (!state)
-                goto finish;
+        assert(state);
 
         r = fopen_temporary(link->state_file, &f, &temp_path);
         if (r < 0)