[PATCH] fix handle leak in udev_lib.c

There is a handle leak in failure path in file_map, and the result of
file_map (or the result of the caller of the file_map) is not always
checked.

diff --git a/udev_lib.c b/udev_lib.c
index 16b473f57608058177702f46b162faeb13f7bf99..8f6aa4237734a906c609484c0b8e6626cc7ecbc8 100644 (file)
--- a/udev_lib.c
+++ b/udev_lib.c
@@ -124,11 +124,13 @@ int file_map(const char *filename, char **buf, size_t *bufsize)
        }
 
        if (fstat(fd, &stats) < 0) {
+               close(fd);
                return -1;
        }
 
        *buf = mmap(NULL, stats.st_size, PROT_READ, MAP_SHARED, fd, 0);
        if (*buf == MAP_FAILED) {
+               close(fd);
                return -1;
        }
        *bufsize = stats.st_size;