chiark / gitweb /
net: initialize structs when declaring them/do not clobber caller variables
authorLennart Poettering <lennart@poettering.net>
Fri, 21 Feb 2014 20:23:40 +0000 (21:23 +0100)
committerLennart Poettering <lennart@poettering.net>
Fri, 21 Feb 2014 20:23:40 +0000 (21:23 +0100)
Just two minor style fixes...

src/udev/net/ethtool-util.c

index aaba94c..18d44fc 100644 (file)
@@ -64,25 +64,26 @@ int ethtool_connect(int *ret) {
 }
 
 int ethtool_get_driver(int fd, const char *ifname, char **ret) {
-        struct ifreq ifr;
-        struct ethtool_drvinfo ecmd;
+        struct ethtool_drvinfo ecmd = {
+                .cmd = ETHTOOL_GDRVINFO
+        };
+        struct ifreq ifr = {
+                .ifr_data = (void*) &ecmd
+        };
+        char *d;
         int r;
 
-        zero(ecmd);
-        ecmd.cmd = ETHTOOL_GDRVINFO;
-
-        zero(ifr);
         strscpy(ifr.ifr_name, IFNAMSIZ, ifname);
-        ifr.ifr_data = (void *)&ecmd;
 
         r = ioctl(fd, SIOCETHTOOL, &ifr);
         if (r < 0)
                 return -errno;
 
-        *ret = strdup(ecmd.driver);
-        if (!*ret)
+        d = strdup(ecmd.driver);
+        if (!d)
                 return -ENOMEM;
 
+        *ret = d;
         return 0;
 }