test-bus-policy: silence coverity

Check if strjoin worked and also use _cleanup_free_ since we are
here.

Found with Coverity. Fixes CID#1241962

diff --git a/src/bus-proxyd/test-bus-policy.c b/src/bus-proxyd/test-bus-policy.c
index 900e4d2..7bcebef 100644 (file)
--- a/src/bus-proxyd/test-bus-policy.c
+++ b/src/bus-proxyd/test-bus-policy.c
@@ -46,18 +46,17 @@
 
 static int test_policy_load(Policy *p, const char *name)
 {
 
 static int test_policy_load(Policy *p, const char *name)
 {

-        char *path;
+        _cleanup_free_ char *path = NULL;

         int r = 0;
 
         path = strjoin(TEST_DIR, "/bus-policy/", name, NULL);
         int r = 0;
 
         path = strjoin(TEST_DIR, "/bus-policy/", name, NULL);

+        assert_se(path);

 
         if (access(path, R_OK) == 0)
                 policy_load(p, STRV_MAKE(path));
         else
                 r = -ENOENT;
 
 
         if (access(path, R_OK) == 0)
                 policy_load(p, STRV_MAKE(path));
         else
                 r = -ENOENT;
 

-        free(path);
-

         return r;
 }
 
         return r;
 }