chiark / gitweb /
manager: cast mkdir() result to (void) to make sure coverity is quiet
authorLennart Poettering <lennart@poettering.net>
Fri, 7 Nov 2014 01:05:50 +0000 (02:05 +0100)
committerLennart Poettering <lennart@poettering.net>
Fri, 7 Nov 2014 01:05:50 +0000 (02:05 +0100)
Also simplify the code a bit by moving mkdir to the common path.

src/core/manager.c

index 129f6dd..e596494 100644 (file)
@@ -662,11 +662,9 @@ static int manager_setup_notify(Manager *m) {
                         return -errno;
                 }
 
-                if (m->running_as == SYSTEMD_SYSTEM) {
+                if (m->running_as == SYSTEMD_SYSTEM)
                         m->notify_socket = strdup("/run/systemd/notify");
-                        if (!m->notify_socket)
-                                return log_oom();
-                } else {
+                else {
                         const char *e;
 
                         e = getenv("XDG_RUNTIME_DIR");
@@ -676,11 +674,11 @@ static int manager_setup_notify(Manager *m) {
                         }
 
                         m->notify_socket = strappend(e, "/systemd/notify");
-                        if (!m->notify_socket)
-                                return log_oom();
-
-                        mkdir_parents_label(m->notify_socket, 0755);
                 }
+                if (!m->notify_socket)
+                        return log_oom();
+
+                (void) mkdir_parents_label(m->notify_socket, 0755);
 
                 strncpy(sa.un.sun_path, m->notify_socket, sizeof(sa.un.sun_path)-1);
                 r = bind(fd, &sa.sa, offsetof(struct sockaddr_un, sun_path) + strlen(sa.un.sun_path));