chiark / gitweb /
journal-remote: fix client_cert memory leak
authorMichal Schmidt <mschmidt@redhat.com>
Tue, 17 Feb 2015 09:36:57 +0000 (10:36 +0100)
committerMichal Schmidt <mschmidt@redhat.com>
Tue, 17 Feb 2015 09:36:57 +0000 (10:36 +0100)
Found by Valgrind while testing the previous memory leak fix.

src/journal-remote/microhttpd-util.c

index de9c6ab..a95fff1 100644 (file)
@@ -239,10 +239,14 @@ static int get_auth_dn(gnutls_x509_crt_t client_cert, char **buf) {
         return 0;
 }
 
+static inline void gnutls_x509_crt_deinitp(gnutls_x509_crt_t *p) {
+        gnutls_x509_crt_deinit(*p);
+}
+
 int check_permissions(struct MHD_Connection *connection, int *code, char **hostname) {
         const union MHD_ConnectionInfo *ci;
         gnutls_session_t session;
-        gnutls_x509_crt_t client_cert;
+        _cleanup_(gnutls_x509_crt_deinitp) gnutls_x509_crt_t client_cert = NULL;
         _cleanup_free_ char *buf = NULL;
         int r;