chiark / gitweb /
terminal: fix uninitialized variable in strerror() log message
authorDavid Herrmann <dh.herrmann@gmail.com>
Thu, 11 Sep 2014 15:20:11 +0000 (17:20 +0200)
committerDavid Herrmann <dh.herrmann@gmail.com>
Thu, 11 Sep 2014 15:20:11 +0000 (17:20 +0200)
We currently print weird error-messages if xkbcommon fails (which cannot
fail so far, but might in the future). Fix the uninitialized variable
warnings by setting 'r' correctly.
Thanks to Philippe De Swert for catching this (via coverity).

src/libsystemd-terminal/idev-keyboard.c

index ab9e481..d5936b7 100644 (file)
@@ -770,8 +770,10 @@ static int keyboard_feed_evdev(idev_keyboard *k, idev_data *data) {
                 /* TODO: update LEDs */
         }
 
-        if (num < 0)
+        if (num < 0) {
+                r = num;
                 goto error;
+        }
 
         r = keyboard_fill(k, &k->evdata, data->resync, ev->code, ev->value, num, keysyms);
         if (r < 0)