[PATCH] sparse cleanups on the tree

diff --git a/namedev_parse.c b/namedev_parse.c
index 7e3783320256818948a547d744e0062bd5fe3c2e..22e3523f3d8b67c474d245a15359f2d1e2157993 100644 (file)
--- a/namedev_parse.c
+++ b/namedev_parse.c
@@ -441,7 +441,7 @@ exit:
        return retval;
 }
 
        return retval;
 }
 

-int namedev_init_rules()
+int namedev_init_rules(void)

 {
        struct stat stats;
 
 {
        struct stat stats;
 


@@ -453,7 +453,7 @@ int namedev_init_rules()
                                         udev_rules_filename, RULEFILE_SUFFIX);
 }
 
                                         udev_rules_filename, RULEFILE_SUFFIX);
 }
 

-int namedev_init_permissions()
+int namedev_init_permissions(void)

 {
        struct stat stats;
 
 {
        struct stat stats;
 

diff --git a/udev.c b/udev.c
index dfb2baddbc34dfdabbf5264bd9abf587d68304a2..839bfa6520299461e63d6261d01a2bc173df15d7 100644 (file)
--- a/udev.c
+++ b/udev.c
@@ -28,6 +28,7 @@
 #include <ctype.h>
 #include <errno.h>
 #include <signal.h>
 #include <ctype.h>
 #include <errno.h>
 #include <signal.h>

+#include <unistd.h>

 
 #include "libsysfs/sysfs/libsysfs.h"
 #include "udev.h"
 
 #include "libsysfs/sysfs/libsysfs.h"
 #include "udev.h"

diff --git a/udev_remove.c b/udev_remove.c
index 0dcec731ead0457745c49771b4a061448f5d64f4..cd9d27f8dce2836f5576be021f732f0880e66b13 100644 (file)
--- a/udev_remove.c
+++ b/udev_remove.c
@@ -28,6 +28,7 @@
 #include <fcntl.h>
 #include <unistd.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <unistd.h>
 #include <errno.h>

+#include <sys/stat.h>

 
 #include "udev.h"
 #include "udev_lib.h"
 
 #include "udev.h"
 #include "udev_lib.h"

diff --git a/udevd.c b/udevd.c
index 421c25a6e8df7fcdf8eb9ba31e0730bd1ba9f06a..9e0f71b58302ae7efa533f4c43ab2db4c3311a04 100644 (file)
--- a/udevd.c
+++ b/udevd.c
@@ -177,7 +177,7 @@ static struct hotplug_msg *running_with_devpath(struct hotplug_msg *msg)
 }
 
 /* exec queue management routine executes the events and delays events for the same devpath */
 }
 
 /* exec queue management routine executes the events and delays events for the same devpath */

-static void exec_queue_manager()
+static void exec_queue_manager(void)

 {
        struct hotplug_msg *loop_msg;
        struct hotplug_msg *tmp_msg;
 {
        struct hotplug_msg *loop_msg;
        struct hotplug_msg *tmp_msg;


@@ -207,7 +207,7 @@ static void msg_move_exec(struct hotplug_msg *msg)
 }
 
 /* msg queue management routine handles the timeouts and dispatches the events */
 }
 
 /* msg queue management routine handles the timeouts and dispatches the events */

-static void msg_queue_manager()
+static void msg_queue_manager(void)

 {
        struct hotplug_msg *loop_msg;
        struct hotplug_msg *tmp_msg;
 {
        struct hotplug_msg *loop_msg;
        struct hotplug_msg *tmp_msg;


@@ -241,7 +241,7 @@ recheck:
        if (list_empty(&msg_list) == 0) {
                struct itimerval itv = {{0, 0}, {EVENT_TIMEOUT_SEC - msg_age, 0}};
                dbg("next event expires in %li seconds", EVENT_TIMEOUT_SEC - msg_age);
        if (list_empty(&msg_list) == 0) {
                struct itimerval itv = {{0, 0}, {EVENT_TIMEOUT_SEC - msg_age, 0}};
                dbg("next event expires in %li seconds", EVENT_TIMEOUT_SEC - msg_age);

-               setitimer(ITIMER_REAL, &itv, 0);
+               setitimer(ITIMER_REAL, &itv, NULL);

        }
 }
 
        }
 }
 


@@ -366,11 +366,11 @@ static void udev_done(int pid)
        }
 }
 
        }
 }
 

-static void reap_kids()
+static void reap_kids(void)

 {
        /* reap all dead children */
        while(1) {
 {
        /* reap all dead children */
        while(1) {

-               int pid = waitpid(-1, 0, WNOHANG);
+               int pid = waitpid(-1, NULL, WNOHANG);

                if ((pid == -1) || (pid == 0))
                        break;
                udev_done(pid);
                if ((pid == -1) || (pid == 0))
                        break;
                udev_done(pid);


@@ -380,7 +380,7 @@ static void reap_kids()
 /* just read everything from the pipe and clear the flag,
  * the useful flags were set in the signal handler
  */
 /* just read everything from the pipe and clear the flag,
  * the useful flags were set in the signal handler
  */

-static void user_sighandler()
+static void user_sighandler(void)

 {
        int sig;
        while(1) {
 {
        int sig;
        while(1) {