chiark / gitweb /
rules_generator: remove policy from write_cd_rules
authorMarco d'Itri <md@Linux.IT>
Tue, 7 Aug 2007 08:37:58 +0000 (10:37 +0200)
committerKay Sievers <kay.sievers@vrfy.org>
Tue, 7 Aug 2007 08:37:58 +0000 (10:37 +0200)
The decision about when to create by-id or by-path persistent rules should
be made in the generator rules file where it's obvious and easy to modify
locally, not in the script.

extras/rule_generator/75-cd-aliases-generator.rules
extras/rule_generator/write_cd_rules

index c3eb887..e357a6a 100644 (file)
@@ -1,3 +1,6 @@
 # these rules generate rules for the /dev/{cdrom,dvd,...} symlinks
 
+# the path of removable devices changes frequently
+ACTION=="add", SUBSYSTEM=="block", SUBSYSTEMS=="usb|ieee1394", ENV{ID_CDROM}=="?*", ENV{GENERATED}!="?*", PROGRAM="write_cd_rules by-id", SYMLINK+="%c"
+
 ACTION=="add", SUBSYSTEM=="block", ENV{ID_CDROM}=="?*", ENV{GENERATED}!="?*", PROGRAM="write_cd_rules", SYMLINK+="%c"
index bd951c5..1dbe6b7 100644 (file)
@@ -53,15 +53,7 @@ fi
 if [ "$1" ]; then
        METHOD="$1"
 else
-       case "$ID_BUS" in
-               usb|ieee1394)
-               METHOD='by-id'
-               ;;
-
-               *)
-               METHOD='by-path'
-               ;;
-       esac
+       METHOD='by-path'
 fi
 
 case "$METHOD" in