journal: don't allow journal_file_open() to be called with ret being NULL

diff --git a/src/journal/journal-file.c b/src/journal/journal-file.c
index e778e1c67c19a5f798a6bdd4291557e6272eeeba..6db9955aa5dbc9c8c84f0e682d7a5e837cfcd3aa 100644 (file)
--- a/src/journal/journal-file.c
+++ b/src/journal/journal-file.c
@@ -2012,6 +2012,7 @@ int journal_file_open(
         bool newly_created = false;
 
         assert(fname);
+        assert(ret);
 
         if ((flags & O_ACCMODE) != O_RDONLY &&
             (flags & O_ACCMODE) != O_RDWR)
@@ -2156,9 +2157,7 @@ int journal_file_open(
         if (r < 0)
                 goto fail;
 
-        if (ret)
-                *ret = f;
-
+        *ret = f;
         return 0;
 
 fail: