chiark / gitweb /
test suite: t-check-only-bpd: Check $tmp/.. not ..
authorIan Jackson <ijackson@chiark.greenend.org.uk>
Fri, 28 Sep 2018 17:04:03 +0000 (18:04 +0100)
committerIan Jackson <ijackson@chiark.greenend.org.uk>
Fri, 28 Sep 2018 17:04:03 +0000 (18:04 +0100)
The test might call t-ok in $p, say, or in $tmp.

The effect of this bug was that in tests where t-ok was called in
$tmp, it looked in $tmp/.. which might contain anything, rather than
$tmp as intended.  That means the test was not effective.

Also it causes a spurious failure of t-import-nonnative in the Ubuntu
CI infrastructure, where $AUTOPKGTEST_TMP/../autopkgtest-satdep.deb
happens to exist.

Reported-by: Mattia Rizzolo <mattia@debian.org>
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
tests/lib

index 57b9e38..a4f307f 100644 (file)
--- a/tests/lib
+++ b/tests/lib
@@ -407,8 +407,8 @@ t-git-fsck () {
 t-check-only-bpd () {
        if [ "$bpd" = .. ]; then return; fi
        t-files-notexist \
-               ../*.{deb,changes,dsc,buildinfo} \
-               ../*.{tar,diff}.*
+               $tmp/*.{deb,changes,dsc,buildinfo} \
+               $tmp/*.{tar,diff}.*
 }
 
 t-fscks () {