infrastructure: Do not reject commits with no author/committer name

But still insist on email address and date).

Peter Green reports that eg 71e128629ec786f3 in upstream xen.git is
such a commit (and is accepted by github).

Closes:#851716.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

diff --git a/debian/changelog b/debian/changelog
index c73480b760c0e476f397bd54f3bef1e4b363710f..b1c7db172649819e7d476435bd100050616db5e9 100644 (file)
--- a/debian/changelog
+++ b/debian/changelog
@@ -11,6 +11,10 @@ dgit (3.6~) unstable; urgency=medium
   Infrastructure:
   * Properly honour NOCOMMITCHECK policy hook exit status.
     Closes:#851800.
   Infrastructure:
   * Properly honour NOCOMMITCHECK policy hook exit status.
     Closes:#851800.

+  * Do not reject commits with no author/committer name (but still insist
+    on email address and date).  Peter Green reports that eg
+    71e128629ec786f3 in upstream xen.git is such a commit (and is accepted
+    by github).  Closes:#851716.

 
   Test suite:
   * downstream-gitless: Test import of .dsc from unknown distro.
 
   Test suite:
   * downstream-gitless: Test import of .dsc from unknown distro.

diff --git a/infra/dgit-repos-server b/infra/dgit-repos-server
index aa6fecd2eb72028c79387228cee3364a1c3f40c5..6131774e7c43c7e2816cad08bfbcc3b54329947e 100755 (executable)
--- a/infra/dgit-repos-server
+++ b/infra/dgit-repos-server
@@ -897,8 +897,8 @@ sub checks () {
 
     # defend against commits generated by #849041
     if (!($policy & NOCOMMITCHECK)) {
 
     # defend against commits generated by #849041
     if (!($policy & NOCOMMITCHECK)) {

-       my @checks = qw(%an %ae %at
-                       %cn %ce %ct);
+       my @checks = qw(%ae %at
+                       %ce %ct);

        my @chk = qw(git log -z);
        push @chk, '--pretty=tformat:%H%n'.
            (join "", map { $_, '%n' } @checks);
        my @chk = qw(git log -z);
        push @chk, '--pretty=tformat:%H%n'.
            (join "", map { $_, '%n' } @checks);