chiark / gitweb /
dgit: avoid "Use of uninitialized value $got in concatenation"
authorIan Jackson <ijackson@chiark.greenend.org.uk>
Sat, 8 Jul 2017 16:59:55 +0000 (17:59 +0100)
committerIan Jackson <ijackson@chiark.greenend.org.uk>
Sat, 8 Jul 2017 16:59:55 +0000 (17:59 +0100)
When dgit wanted to report that a file it downloaded had the wrong
checksum, it would instead crash with this message.  This was due to
complete_file_from_dsc's $got (which is relied on by the callers of
$checkhash) being shadowed inside $checkhash.

This is part of #867185/#867185.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
dgit

diff --git a/dgit b/dgit
index 6134f5c..8d7af11 100755 (executable)
--- a/dgit
+++ b/dgit
@@ -2519,7 +2519,7 @@ sub complete_file_from_dsc ($$;$) {
        $fi->{Digester}->reset();
        $fi->{Digester}->addfile(*F);
        F->error and die $!;
-       my $got = $fi->{Digester}->hexdigest();
+       $got = $fi->{Digester}->hexdigest();
        return $got eq $fi->{Hash};
     };