chiark / gitweb /
dgit: curl --proto-redir settings: do not use qw() for ...,...
authorIan Jackson <ijackson@chiark.greenend.org.uk>
Sat, 8 Jul 2017 17:37:33 +0000 (18:37 +0100)
committerIan Jackson <ijackson@chiark.greenend.org.uk>
Sat, 8 Jul 2017 17:53:59 +0000 (18:53 +0100)
This syntax generates the following spurious warning with buster's
perl (but not with stretch's):
  Possible attempt to separate words with commas at /home/ian/things/Dgit/2dgit/dgit line 103.

It seems better to keep this warning everywhere else, and using a
different syntax is easier than disabling it around this construct.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
dgit

diff --git a/dgit b/dgit
index 2685b6ca9e7ca4f2bc64a6b57591765b047fbe98..a4c9640475fcfae13a6093631a2012931fc51648 100755 (executable)
--- a/dgit
+++ b/dgit
@@ -100,7 +100,7 @@ our $rewritemap = 'dgit-rewrite/map';
 
 our (@git) = qw(git);
 our (@dget) = qw(dget);
-our (@curl) = qw(curl --proto-redir -all,http,https -L);
+our (@curl) = (qw(curl --proto-redir), '-all,http,https', qw(-L));
 our (@dput) = qw(dput);
 our (@debsign) = qw(debsign);
 our (@gpg) = qw(gpg);