chiark / gitweb /
Split brain: Do not leave STDOUT redirected to /dev/null (!)
authorIan Jackson <ijackson@chiark.greenend.org.uk>
Sat, 16 Jul 2016 10:53:08 +0000 (11:53 +0100)
committerIan Jackson <ijackson@chiark.greenend.org.uk>
Sat, 16 Jul 2016 15:47:48 +0000 (16:47 +0100)
We use runcmd shell_cmd for gbp pq import, and the other commands not
produce undesirable output.

dgit

diff --git a/dgit b/dgit
index 455b375..66349e4 100755 (executable)
--- a/dgit
+++ b/dgit
@@ -2594,7 +2594,6 @@ sub quiltify_splitbrain ($$$$$$) {
        ($diffbits->{O2A} & 01)) { # some patches
        quiltify_splitbrain_needed();
        progress "creating patches-applied version using gbp pq";
-       open STDOUT, ">/dev/null" or die $!;
        runcmd shell_cmd 'exec >/dev/null', @gbp, qw(pq import);
        # gbp pq import creates a fresh branch; push back to dgit-view
        runcmd @git, qw(update-ref refs/heads/dgit-view HEAD);