dgit: Demand that all clean modes are handled by clean_tree_check

We've dealt with all the cases now, so we can add the default.

Also, in the test suite.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

diff --git a/dgit b/dgit
index f5092f5d0b90b91ade27dd508b906320acb36c43..e10483894bb1084ae5693cf94c1347d959216c1a 100755 (executable)
--- a/dgit
+++ b/dgit
@@ -6243,6 +6243,8 @@ sub clean_tree_check () {
        # deleted.  Since we're not, and not using the working tree
        # anyway, we can just ignore them - nothing will use them.
     } elsif ($cleanmode eq 'none') {
+    } else {
+       confess "$cleanmode ?";
     }
 }
 

diff --git a/tests/lib-build-modes b/tests/lib-build-modes
index 78ae236f3c2584609931ee9442508a30b4cf75bc..bc8b2aa8113a670072573a0d5381d1f9b671ab93 100644 (file)
--- a/tests/lib-build-modes
+++ b/tests/lib-build-modes
@@ -161,7 +161,6 @@ bm-compute-expected () {
        none|Cnone)     ;;
        Cdpkg-source*)  ;; # handled below
        Cgit|Cgit-ff)   ;;
-       C*)             echo "TODO bm eff_cleanmode=$eff_cleanmode" ;;
        *)              fail "t-compute-expected-run $cleanmode ??" ;;
        esac