Split brain: Move GIT_COMMITTER_* setting to quiltify_splitbrain toplevel (nfc)

We want this to apply to any commits we use git to make, not just
gbp-pq.

diff --git a/dgit b/dgit
index 4edf9827fe181a3c00eedf895b021f3aa316329e..73432bce8970ec4384feb0eed9fb2eb4841c2334 100755 (executable)
--- a/dgit
+++ b/dgit
@@ -2559,15 +2559,16 @@ sub quiltify_splitbrain ($$) {
        $diffbits = { %$diffbits };
        $_ = !!$_ foreach values %$diffbits;
     }
        $diffbits = { %$diffbits };
        $_ = !!$_ foreach values %$diffbits;
     }

+    # We would like any commits we generate to be reproducible
+    my @authline = clogp_authline($clogp);
+    local $ENV{GIT_COMMITTER_NAME} =  $authline[0];
+    local $ENV{GIT_COMMITTER_EMAIL} = $authline[1];
+    local $ENV{GIT_COMMITTER_DATE} =  $authline[2];

     if ($quilt_mode =~ m/gbp|unapplied/ &&
        ($diffbits->{O2A} & 01) && # some patches
        !($diffbits->{H2O} & 01)) { # but HEAD is like orig
        quiltify_splitbrain_needed();
        progress "creating patches-applied version using gbp-pq";
     if ($quilt_mode =~ m/gbp|unapplied/ &&
        ($diffbits->{O2A} & 01) && # some patches
        !($diffbits->{H2O} & 01)) { # but HEAD is like orig
        quiltify_splitbrain_needed();
        progress "creating patches-applied version using gbp-pq";

-       my @authline = clogp_authline($clogp);
-       local $ENV{GIT_COMMITTER_NAME} =  $authline[0];
-       local $ENV{GIT_COMMITTER_EMAIL} = $authline[1];
-       local $ENV{GIT_COMMITTER_DATE} =  $authline[2];

        open STDOUT, ">/dev/null" or die $!;
        runcmd shell_cmd 'exec >/dev/null', @gbppq, qw(import);
     }
        open STDOUT, ">/dev/null" or die $!;
        runcmd shell_cmd 'exec >/dev/null', @gbppq, qw(import);
     }