chiark / gitweb /
failedcmd prints $us, not $_[0] - ie, dgit doesn't pretend, in the error message...
authorIan Jackson <ijackson@chiark.greenend.org.uk>
Sun, 19 Jan 2014 02:21:15 +0000 (02:21 +0000)
committerIan Jackson <ijackson@chiark.greenend.org.uk>
Sun, 19 Jan 2014 02:21:15 +0000 (02:21 +0000)
debian/changelog
dgit

index af72941..32c0680 100644 (file)
@@ -9,6 +9,8 @@ dgit (0.21~~iwj) unstable; urgency=medium
 
   Error message improvements:
   * Use failedcmd to report errors when ssh psql fails.  Closes:#734281.
+  * failedcmd prints $us, not $_[0] - ie, dgit doesn't pretend,
+    in the error message, to be its child.
   * Do not report the (irrelevant) $? when madison parsing fails.
 
   Packaging improvements:
diff --git a/dgit b/dgit
index 94b9ab1..0182b6f 100755 (executable)
--- a/dgit
+++ b/dgit
@@ -332,7 +332,7 @@ sub printcmd {
 }
 
 sub failedcmd {
-    { local ($!); printcmd \*STDERR, "$_[0]: failed command:", @_ or die $!; };
+    { local ($!); printcmd \*STDERR, "$us: failed command:", @_ or die $!; };
     if ($!) {
        fail "failed to fork/exec: $!";
     } elsif (!($? & 0xff)) {