tg.sh: Check for read permissions of help files

We currently check only for '-f' but we need to have read permissions as well.

And help files don't need the execution bit set.

[pb: Simplified test.]

Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
Signed-off-by: Petr Baudis <pasky@suse.cz>

diff --git a/Makefile b/Makefile
index 2975f295d637bd1d840ff57436e032614e2bd231..1352d03fad6ceb36095b2cd8388172849b0914c9 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -37,7 +37,7 @@ install:: all
        install -d -m 755 "$(hooksdir)"
        install $(hooks_out) "$(hooksdir)"
        install -d -m 755 "$(sharedir)"
-       install $(help_out) "$(sharedir)"
+       install -m 644 $(help_out) "$(sharedir)"
 
 clean::
        rm -f tg $(commands_out) $(hooks_out) $(help_out)

diff --git a/tg.sh b/tg.sh
index 179f0de21bdfc37893afa4d3f90f43460d330b6c..ead236154cc023c554638abe7503e0b8b3704148 100644 (file)
--- a/tg.sh
+++ b/tg.sh
@@ -167,7 +167,7 @@ do_help()
 
                echo "TopGit v0.1 - A different patch queue manager"
                echo "Usage: tg ($cmds|help) ..."
-       elif [ -f "@sharedir@/tg-$1.txt" ] ; then
+       elif [ -r "@sharedir@/tg-$1.txt" ] ; then
                cat "@sharedir@/tg-$1.txt"
        else
                echo "`basename $0`: no help for $1" 1>&2