In some pathological configurations, it can happen that a packet is
received from the kernel by a netlink which has no clients (that is,
where netlink_inst_reg has not been called).
Don't crash when this happens; instead, print a log message including
the source and destination addresses.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
* Updates to release checklist in Makefile.in.
* Fix formatting error in secnet.8 manpage.
* Internal code rearrangements and improvements.
* Updates to release checklist in Makefile.in.
* Fix formatting error in secnet.8 manpage.
* Internal code rearrangements and improvements.
+ * Fix netlink SEGV on clientless netlinks (i.e. configuration error).
}
/* Deliver a packet _to_ client; used after we have decided
}
/* Deliver a packet _to_ client; used after we have decided
- * what to do with it. */
+ * what to do with it (and just to check that the client has
+ * actually registered a delivery function with us). */
static void netlink_client_deliver(struct netlink *st,
struct netlink_client *client,
uint32_t source, uint32_t dest,
struct buffer_if *buf)
{
static void netlink_client_deliver(struct netlink *st,
struct netlink_client *client,
uint32_t source, uint32_t dest,
struct buffer_if *buf)
{
+ if (!client->deliver) {
+ string_t s,d;
+ s=ipaddr_to_string(source);
+ d=ipaddr_to_string(dest);
+ Message(M_ERR,"%s: dropping %s->%s, client not registered\n",
+ st->name,s,d);
+ free(s); free(d);
+ BUF_FREE(buf);
+ return;
+ }
client->deliver(client->dst, buf);
client->outcount++;
}
client->deliver(client->dst, buf);
client->outcount++;
}