chiark
/
gitweb
/
~ian
/
secnet.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
eb99aed
)
slip: Remove an incorrect XXX comment
author
Ian Jackson
<ijackson@chiark.greenend.org.uk>
Sat, 27 Sep 2014 13:28:20 +0000
(14:28 +0100)
committer
Ian Jackson
<ijackson@chiark.greenend.org.uk>
Mon, 29 Sep 2014 15:20:02 +0000
(16:20 +0100)
There is no need to strdup anything before calling exec (or exit, of
course).
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
slip.c
patch
|
blob
|
history
diff --git
a/slip.c
b/slip.c
index c846b39a08a7e44f319d7bf6edc9ee0d2b047496..abfd922e0aa97ad39db6b0300083a0ee149dc93c 100644
(file)
--- a/
slip.c
+++ b/
slip.c
@@
-273,8
+273,6
@@
static void userv_entry(void *sst)
dup2(st->out,1);
setsid();
- /* XXX We really should strdup() all of argv[] but because we'll just
- exit anyway if execvp() fails it doesn't seem worth bothering. */
execvp(st->path,(char *const*)st->argv);
perror("userv-entry: execvp()");
exit(1);