chiark / gitweb /
gpgconf: No ENOENT warning with --change-options et al.
authorWerner Koch <wk@gnupg.org>
Mon, 13 Feb 2017 18:38:53 +0000 (19:38 +0100)
committerDaniel Kahn Gillmor <dkg@fifthhorseman.net>
Mon, 18 Sep 2017 20:41:12 +0000 (21:41 +0100)
* tools/gpgconf-comp.c (retrieve_options_from_program): Check ERRNO
before printing a warning.
--

It is common that a conf files does not exist - thus we should not
print a warning.

GnuPG-bug-id: 2944

BTW: The error messages in gpgconf should be reworked to match those
of the other components.

Signed-off-by: Werner Koch <wk@gnupg.org>
(cherry picked from commit 30dac0486b6357e84fbe79c612eea940b654e4d1)

Gbp-Pq: Name 0036-gpgconf-No-ENOENT-warning-with-change-options-et-al.patch

tools/gpgconf-comp.c

index 180fd65c29aa998fccf2e16c8f0196f2a8e779c2..a0d9659698e17bcc1c8a1cc6dbd0d8cb6bc441bc 100644 (file)
@@ -2163,8 +2163,11 @@ retrieve_options_from_program (gc_component_t component, gc_backend_t backend)
 
   config = es_fopen (config_filename, "r");
   if (!config)
-    gc_error (0, errno, "warning: can not open config file %s",
-             config_filename);
+    {
+      if (errno != ENOENT)
+        gc_error (0, errno, "warning: can not open config file %s",
+                  config_filename);
+    }
   else
     {
       while ((length = es_read_line (config, &line, &line_len, NULL)) > 0)