Bug#972315: sysvinit still misses B-D: libcrypt-dev

[Adam Borowski]

On Tue, Nov 22, 2022 at 11:20:07AM +0100, Helmut Grohne wrote:
> On Tue, Nov 22, 2022 at 11:01:31AM +0100, Adam Borowski wrote:
> > sysvinit (3.05-7) unstable; urgency=medium
> >   * Drop libcrypt-dev from B-Depends, we don't ship sulogin since Stretch
> >     which was what we needed the library for.

> Yes, I got a build failure when I tried making libcrypt-dev
> non-build-essential (which is the goal here).

> A relatively simple method to simulate its absence is:
> | sbuild -d unstable --starting-build-commands="rm /usr/include/crypt.h" sysvinit

> | sulogin.c:42:10: fatal error: crypt.h: No such file or directory
> |    42 | #include <crypt.h>    /* added to make this compile on Fedora 28 */
> |       |          ^~~~~~~~~

> So not being shipped does not seem to imply not being built. Can you
> figure out how to make it not build sulogin? That would be a better
> solution than adding back the dependency indeed.

As this is a change in upstream code, I've submitted a PR there:
    https://github.com/slicer69/sysvinit/pull/15

Do you intend to drop the build-essentiality of libcrypt-dev shortly?  If
not, I'd just let the PR go through the normal flow towards next upstream
release then the package.

An expedited upload is of course an option, but I suspect you're not in
a hurry.


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁
⢿⡄⠘⠷⠚⠋⠀ Quis trollabit ipsos trollos?
⠈⠳⣄⠀⠀⠀⠀