Bug#972315: sysvinit still misses B-D: libcrypt-dev

[Helmut Grohne]

Hi Adam,

On Tue, Nov 22, 2022 at 11:01:31AM +0100, Adam Borowski wrote:
> sysvinit (3.05-7) unstable; urgency=medium
>   * Drop libcrypt-dev from B-Depends, we don't ship sulogin since Stretch
>     which was what we needed the library for.
> 
> The sulogin executable is no longer needed (it's built by util-linux
> nowadays), and its source inside src:sysvinit is dormant.  I've just
> re-checked: the package builds and cross-builds successfully.
> 
> Is there a reason for this B-Dependency that I missed?

Yes, I got a build failure when I tried making libcrypt-dev
non-build-essential (which is the goal here).

A relatively simple method to simulate its absence is:

| sbuild -d unstable --starting-build-commands="rm /usr/include/crypt.h" sysvinit

That turns up:

| cc -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -ansi -fomit-frame-pointer -fstack-protector-strong -W -Wall -Wunreachable-code -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -D_XOPEN_SOURCE -D_GNU_SOURCE -DVERSION=\"3.05\"  -DACCTON_OFF -DWITH_SELINUX  -c -o sulogin.o sulogin.c
| sulogin.c:42:10: fatal error: crypt.h: No such file or directory
|    42 | #include <crypt.h>    /* added to make this compile on Fedora 28 */
|       |          ^~~~~~~~~
| compilation terminated.
| make[4]: *** [<builtin>: sulogin.o] Error 1
| make[4]: Leaving directory '/<<PKGBUILDDIR>>/src'
| make[3]: *** [Makefile:7: all] Error 2
| make[3]: Leaving directory '/<<PKGBUILDDIR>>'
| make[2]: *** [debian/rules:35: override_dh_auto_build] Error 2
| make[2]: Leaving directory '/<<PKGBUILDDIR>>'
| make[1]: *** [debian/rules:32: build-arch] Error 2
| make[1]: Leaving directory '/<<PKGBUILDDIR>>'
| make: *** [debian/rules:32: binary] Error 2
| dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

So not being shipped does not seem to imply not being built. Can you
figure out how to make it not build sulogin? That would be a better
solution than adding back the dependency indeed.

Helmut