Bug#501336: Will now activate swapfile swap...done, but there never was one

[Dmitry Bogatov]

control: tags -1 +patch
control: user sysvinit at packages.debian.org
control: usertag -1 +objections

[2008-10-06 19:33] Sven Joachim <svenjoac at gmx.de>
> On 2008-10-06 19:14 +0200, jidanni at jidanni.org wrote:
>
> > SJ> Yes.  So what?
> >
> > Well, please don't say "...Done" if indeed the action was not done.
> > There should be a failure message.
>
> No, since it is perfectly normal not to have swap files.
>
> > Or say "will now activate swap ... if there are any".
>
> Or, better, deduce from /etc/fstab if there are any swap files and not
> print a message at all if there aren't.  That would make some sense (no,
> I'm not going to implement this myself).

Distinguishing swap file from file partitions can't be done purely by
parsing /etc/fstab (unless you assume, that swapfile is never under
/dev), so I propose to just slightly change wording.

Opinions?

From 61bf55ac4057958bc8870aa4685ed1efea5cbbbd Mon Sep 17 00:00:00 2001
From: Dmitry Bogatov <KAction at debian.org>
Date: Wed, 20 Feb 2019 21:40:40 +0000
Subject: [PATCH] Improve logging about swapfile activation (Closes: #501336)

---
 debian/src/initscripts/etc/init.d/mountall.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/src/initscripts/etc/init.d/mountall.sh b/debian/src/initscripts/etc/init.d/mountall.sh
index 1c7afe0c..129a4325 100755
--- a/debian/src/initscripts/etc/init.d/mountall.sh
+++ b/debian/src/initscripts/etc/init.d/mountall.sh
@@ -74,11 +74,11 @@ do_start() {
 	else
 		if [ "$VERBOSE" = no ]
 		then
-			log_action_begin_msg "Activating swapfile swap"
+			log_action_begin_msg "Activating swapfile swap, if any"
 			swapon -a -e 2>/dev/null || :  # Stifle "Device or resource busy"
 			log_action_end_msg 0
 		else
-			log_daemon_msg "Will now activate swapfile swap"
+			log_daemon_msg "Will now activate swapfile swap, if any"
 			swapon -a -e -v
 			log_action_end_msg $?
 		fi
-- 
        Note, that I send and fetch email in batch, once every 24 hours.
                 If matter is urgent, try https://t.me/kaction
                                                                             --