From: Karl Hasselström <kha@treskal.com>
Date: Fri, 29 May 2009 21:33:50 +0000 (+0100)
Subject: Pass "git config" flags in the right order
X-Git-Tag: v0.15-rc1~11
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~mdw/git/stgit/commitdiff_plain/ba6208ec9f272605607d53db6ea2942b246819e6?ds=sidebyside;hp=-c

Pass "git config" flags in the right order

New enough gits accept the --null and --list flags in any order, but
older gits want --null before --list. So do it the way that's fine
with everyone.

I think (but haven't verified) that git started to accept the flags in
any order after commit d64ec16c2af4ddcf3985d11d5dc28a15db181de5 ("git
config: reorganize to use parseopt") by Felipe Contreras on
2009-02-21, first released in git v1.6.3.

Signed-off-by: Karl Hasselström <kha@treskal.com>
---

ba6208ec9f272605607d53db6ea2942b246819e6
diff --git a/stgit/config.py b/stgit/config.py
index c40756c..dc9c9eb 100644
--- a/stgit/config.py
+++ b/stgit/config.py
@@ -48,7 +48,7 @@ class GitConfig:
         if self.__cache is not None:
             return
         self.__cache = {}
-        lines = Run('git', 'config', '--list', '--null').raw_output()
+        lines = Run('git', 'config', '--null', '--list').raw_output()
         for line in filter(None, lines.split('\0')):
             key, value = line.split('\n', 1)
             self.__cache.setdefault(key, []).append(value)