stgit.el: Handle errors in first phase of stgit squash

Make sure to reload stgit buffer after first phase, and signal an
error if stg squash --save-template fails.

Signed-off-by: Gustav Hållberg <gustav@virtutech.com>
Signed-off-by: Karl Hasselström <kha@treskal.com>

diff --git a/contrib/stgit.el b/contrib/stgit.el
index a5067970dd2a3e43ecc63ab4b64ca2de45a4ab98..93e3fa22d338d2b67e6f08496a1ad02a5393f980 100644 (file)
--- a/contrib/stgit.el
+++ b/contrib/stgit.el
@@ -952,14 +952,27 @@ (defun stgit-squash (patchsyms)
   (interactive (list stgit-marked-patches))
   (when (< (length patchsyms) 2)
     (error "Need at least two patches to squash"))
   (interactive (list stgit-marked-patches))
   (when (< (length patchsyms) 2)
     (error "Need at least two patches to squash"))

-  (let ((edit-buf (get-buffer-create "*StGit edit*"))
+  (let ((stgit-buffer (current-buffer))
+        (edit-buf (get-buffer-create "*StGit edit*"))

         (dir default-directory)
         (sorted-patchsyms (stgit-sort-patches patchsyms)))
     (log-edit 'stgit-confirm-squash t nil edit-buf)
     (set (make-local-variable 'stgit-patchsyms) sorted-patchsyms)
     (setq default-directory dir)
         (dir default-directory)
         (sorted-patchsyms (stgit-sort-patches patchsyms)))
     (log-edit 'stgit-confirm-squash t nil edit-buf)
     (set (make-local-variable 'stgit-patchsyms) sorted-patchsyms)
     (setq default-directory dir)

-    (let ((standard-output edit-buf))
-      (apply 'stgit-run-silent "squash" "--save-template=-" sorted-patchsyms))))
+    (let ((result (let ((standard-output edit-buf))
+                    (apply 'stgit-run-silent "squash"
+                           "--save-template=-" sorted-patchsyms))))
+
+      ;; stg squash may have reordered the patches or caused conflicts
+      (with-current-buffer stgit-buffer
+        (stgit-reload))
+
+      (unless (eq 0 result)
+        (fundamental-mode)
+        (rename-buffer "*StGit error*")
+        (resize-temp-buffer-window)
+        (switch-to-buffer-other-window stgit-buffer)
+        (error "stg squash failed")))))

 
 (defun stgit-confirm-squash ()
   (interactive)
 
 (defun stgit-confirm-squash ()
   (interactive)