Merge branch 'stable'

[stgit] / stgit / lib / git.py

diff --git a/stgit/lib/git.py b/stgit/lib/git.py
index 50dc4f112408e35d9f384a4cf188129d84e18496..35b9bbffeebe578708e264872bc043e67627a56b 100644 (file)
--- a/stgit/lib/git.py
+++ b/stgit/lib/git.py
@@ -204,7 +204,7 @@ class Commitdata(Repr):
                 ) % (tree, parents, self.author, self.committer, self.message)
     @classmethod
     def parse(cls, repository, s):
                 ) % (tree, parents, self.author, self.committer, self.message)
     @classmethod
     def parse(cls, repository, s):

-        cd = cls()
+        cd = cls(parents = [])

         lines = list(s.splitlines(True))
         for i in xrange(len(lines)):
             line = lines[i].strip()
         lines = list(s.splitlines(True))
         for i in xrange(len(lines)):
             line = lines[i].strip()


@@ -433,6 +433,9 @@ class Repository(RunWithEnv):
 class MergeException(exception.StgException):
     pass
 
 class MergeException(exception.StgException):
     pass
 

+class MergeConflictException(MergeException):
+    pass
+

 class Index(RunWithEnv):
     def __init__(self, repository, filename):
         self.__repository = repository
 class Index(RunWithEnv):
     def __init__(self, repository, filename):
         self.__repository = repository


@@ -517,14 +520,18 @@ class IndexAndWorktree(RunWithEnv):
         assert isinstance(ours, Tree)
         assert isinstance(theirs, Tree)
         try:
         assert isinstance(ours, Tree)
         assert isinstance(theirs, Tree)
         try:

-            self.run(['git', 'merge-recursive', base.sha1, '--', ours.sha1,
-                      theirs.sha1],
-                     env = { 'GITHEAD_%s' % base.sha1: 'ancestor',
-                             'GITHEAD_%s' % ours.sha1: 'current',
-                             'GITHEAD_%s' % theirs.sha1: 'patched'}
-                     ).cwd(self.__worktree.directory).discard_output()
+            r = self.run(['git', 'merge-recursive', base.sha1, '--', ours.sha1,
+                          theirs.sha1],
+                         env = { 'GITHEAD_%s' % base.sha1: 'ancestor',
+                                 'GITHEAD_%s' % ours.sha1: 'current',
+                                 'GITHEAD_%s' % theirs.sha1: 'patched'}
+                         ).cwd(self.__worktree.directory)
+            r.discard_output()

         except run.RunException, e:
         except run.RunException, e:

-            raise MergeException('Index/worktree dirty')
+            if r.exitcode == 1:
+                raise MergeConflictException()
+            else:
+                raise MergeException('Index/worktree dirty')

     def changed_files(self):
         return self.run(['git', 'diff-files', '--name-only']).output_lines()
     def update_index(self, files):
     def changed_files(self):
         return self.run(['git', 'diff-files', '--name-only']).output_lines()
     def update_index(self, files):