From: Mark Wooding <mdw@distorted.org.uk>
Date: Sat, 5 Sep 2020 13:57:08 +0000 (+0100)
Subject: footnote.dtx (\fn@endnote): Use `\def', not `\let'.
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~mdw/git/mdwtools/commitdiff_plain/5ca7df6af58f019b8e0b278cd03a4a887e2265aa

footnote.dtx (\fn@endnote): Use `\def', not `\let'.

If the `color' package is loaded /after/ us then it redefines
`\color@begingroup' and `\color@endgroup' to actually do things, but it
won't redefine `\fn@endnote' for obvious reasons.  As a result,
`\fn@startnote' will now open a colour group, but nothing will close it
and one ends up on a debugging odyssey.
---

diff --git a/footnote.dtx b/footnote.dtx
index 64eb689..235b179 100644
--- a/footnote.dtx
+++ b/footnote.dtx
@@ -224,7 +224,7 @@
 % Footnotes are finished off by this macro.  This is the easy bit.
 %
 %    \begin{macrocode}
-\let\fn@endnote\color@endgroup
+\def\fn@endnote{\color@endgroup}
 %    \end{macrocode}
 %
 % \end{macro}