codec/url.c: Always encode whitespace characters.

Vertical whitespace is obviously bad, so this is a longstanding bug; but
all whitespace should really be escaped.

diff --git a/codec/url.c b/codec/url.c
index f502f7cbde1e23d6a8de6a4c1a9d9ecf5305ae9f..4e7f19010606b5ba66dda999ee6785bbfc7e67a6 100644 (file)
--- a/codec/url.c
+++ b/codec/url.c
@@ -67,7 +67,8 @@ static void encode(url_ectx *ctx, dstr *d, const char *p)
        DPUTC(d, '+');
        break;
       default:
        DPUTC(d, '+');
        break;
       default:

-       if ((ctx->f & URLF_LAX) || isalnum((unsigned char)*p))
+       if (!isspace((unsigned char)*p) &&
+           ((ctx->f & URLF_LAX) || isalnum((unsigned char)*p)))

          goto safe;
        else
          goto unsafe;
          goto safe;
        else
          goto unsafe;