X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~mdw/git/mLib/blobdiff_plain/f8509853f72daec365373f9d8c18f63cf8bad54e..85bb21f7edaa024657a09129d52edf66d8ab7fa2:/darray.c diff --git a/darray.c b/darray.c index bee6955..d7967c6 100644 --- a/darray.c +++ b/darray.c @@ -1,6 +1,6 @@ /* -*-c-*- * - * $Id: darray.c,v 1.2 1999/10/28 22:05:28 mdw Exp $ + * $Id: darray.c,v 1.3 1999/10/29 22:59:22 mdw Exp $ * * Dynamically growing dense arrays * @@ -30,6 +30,9 @@ /*----- Revision history --------------------------------------------------* * * $Log: darray.c,v $ + * Revision 1.3 1999/10/29 22:59:22 mdw + * New array adjustment macros for unsigned arguments. + * * Revision 1.2 1999/10/28 22:05:28 mdw * Modify and debug allocation routines. * @@ -115,15 +118,26 @@ void *da_ensure(da_base *b, void *v, size_t sz, size_t n) return (q); } - /* --- Reallocate the array --- */ + /* --- Reallocate the array --- * + * + * If the offset isn't changing, it's sensible to use @realloc@ if + * available. Otherwise the overhead of copying all the data twice + * probably isn't worth it. + */ nsz = v ? b->sz + b->off : (DA_INITSZ >> 1); do nsz <<= 1; while (nsz < rq); - q = xmalloc(nsz * sz); - q += slots * sz; - memcpy(q, p, b->len * sz); - if (p) - free(p - b->off * sz); + if (p && slots == b->off) { + q = xrealloc(p - b->off * sz, nsz * sz); + q += slots * sz; + } else { + q = xmalloc(nsz * sz); + q += slots * sz; + if (p) { + memcpy(q, p, b->len * sz); + free(p - b->off * sz); + } + } b->off = slots; b->sz = nsz - slots; b->unshift = b->push = 0; @@ -194,15 +208,20 @@ void *da_shunt(da_base *b, void *v, size_t sz, size_t n) return (q); } - /* --- Reallocate the array --- */ + /* --- Reallocate the array --- * + * + * The neat @realloc@ code doesn't need to be here: the offset changes + * almost all the time -- that's the whole point of this routine! + */ nsz = v ? b->sz + b->off : (DA_INITSZ >> 1); do nsz <<= 1; while (nsz < rq); q = xmalloc(nsz * sz); q += (nsz - slots) * sz; - memcpy(q, p, b->len * sz); - if (p) + if (p) { + memcpy(q, p, b->len * sz); free(p - b->off * sz); + } b->off = nsz - slots; b->sz = slots; b->unshift = b->push = 0;