From: Mark Wooding Date: Sun, 30 Apr 2006 18:32:43 +0000 (+0100) Subject: mop: Remove &allow-other-keys from methods. X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~mdw/git/lisp/commitdiff_plain/920d2b95c4445a3bc1335634d0004b63148a028c?hp=447aca398f4bb96c4b2b3318ea79ccd29af87075 mop: Remove &allow-other-keys from methods. A more careful reading of the CLOS method congruence rules suggests that these mess up the keyword validity checking. Which is a shame. --- diff --git a/mdw-mop.lisp b/mdw-mop.lisp index 0766e38..92c164f 100644 --- a/mdw-mop.lisp +++ b/mdw-mop.lisp @@ -152,7 +152,7 @@ (defmethod effective-slot-definition-class (call-next-method))) (defmethod initialize-instance :after - ((slot filtered-direct-slot-definition) &key &allow-other-keys) + ((slot filtered-direct-slot-definition) &key) (with-slots (filter) slot (when (and (consp filter) (or (eq (car filter) 'function) @@ -191,7 +191,7 @@ (defclass predicate-class-mixin (compatible-class) returning a non-nil value.")) (defmethod shared-initialize :after - ((class predicate-class-mixin) slot-names &key &allow-other-keys) + ((class predicate-class-mixin) slot-names &key) (declare (ignore slot-names)) (with-slots (predicates) class (dolist (predicate predicates)