From d62c03cd64926d4d120f36e3ca3d2b7518c6e075 Mon Sep 17 00:00:00 2001 Message-Id: From: Mark Wooding Date: Sat, 14 Jun 2008 12:48:39 +0100 Subject: [PATCH] more TODOs Organization: Straylight/Edgeware From: Richard Kettlewell --- disobedience/TODO | 7 ------- disobedience/choose.c | 5 ++++- disobedience/login.c | 4 ++++ disobedience/properties.c | 11 +++++++---- disobedience/users.c | 7 ++++--- 5 files changed, 19 insertions(+), 15 deletions(-) delete mode 100644 disobedience/TODO diff --git a/disobedience/TODO b/disobedience/TODO deleted file mode 100644 index 31168db..0000000 --- a/disobedience/TODO +++ /dev/null @@ -1,7 +0,0 @@ -properties - make return be the same as OK -search - select tracks by tag - -general: - disobedience doesn't like starting up if the server isn't running. diff --git a/disobedience/choose.c b/disobedience/choose.c index 86e60bc..c30d712 100644 --- a/disobedience/choose.c +++ b/disobedience/choose.c @@ -242,7 +242,10 @@ static void choose_populate(GtkTreeRowReference *parent_ref, /* We've reached the end of the new tracks from td[], but there are * further tracks in the tree */ //fprintf(stderr, " deleting\n"); - action = DELETE; + if(choose_is_file(it) == isfile) + action = DELETE; + else + action = SKIP_TREE; } switch(action) { diff --git a/disobedience/login.c b/disobedience/login.c index 5831aa6..b1047d6 100644 --- a/disobedience/login.c +++ b/disobedience/login.c @@ -27,6 +27,10 @@ * window remains. * * It you hit Cancel then the window disappears without saving anything. + * + * TODO + * - escape and return should work + * - cancel/close should be consistent with properties */ #include "disobedience.h" diff --git a/disobedience/properties.c b/disobedience/properties.c index 57ed65d..ade23fb 100644 --- a/disobedience/properties.c +++ b/disobedience/properties.c @@ -1,6 +1,6 @@ /* * This file is part of DisOrder. - * Copyright (C) 2006, 2007 Richard Kettlewell + * Copyright (C) 2006-2008 Richard Kettlewell * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -17,11 +17,14 @@ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 * USA */ - +/** @file disobedience/properties.c + * @brief Track properties editor + * + * TODO: + * - return and escape keys should work + */ #include "disobedience.h" -/* Track properties -------------------------------------------------------- */ - struct prefdata; static void kickoff_namepart(struct prefdata *f); diff --git a/disobedience/users.c b/disobedience/users.c index 0590d69..af42858 100644 --- a/disobedience/users.c +++ b/disobedience/users.c @@ -33,9 +33,10 @@ * When you select 'add' a new empty set of details are displayed to be edited. * Again Apply will commit them. * - * TODO: it would be really nice if the Username entry could be removed and new - * user names entered in the list, rather off in the details panel. This may - * be possible with a sufficiently clever GtkCellRenderer. + * TODO: + * - enter new username in the GtkTreeView + * - escape and enter keys should work + * - should have a cancel or close button, consistent with properties and login */ #include "disobedience.h" -- [mdw]