chiark / gitweb /
Richard Kettlewell [Fri, 13 Jun 2008 13:01:57 +0000 (14:01 +0100)]
Move track sorting to its own function. Only choose_populate() uses
it currently (and has some work left); the CGI will be modified to use
it in due course.
Richard Kettlewell [Fri, 13 Jun 2008 10:41:33 +0000 (11:41 +0100)]
Update choose rows when lookups complete. Makes lengths appear
essentially immediately (at least with a fast local server) rather
than after a delay.
Richard Kettlewell [Fri, 13 Jun 2008 10:40:53 +0000 (11:40 +0100)]
Infrastructure for marking the playing track in a different color; not
currently enabled.
Richard Kettlewell [Fri, 13 Jun 2008 10:02:05 +0000 (11:02 +0100)]
Rearrange choose columns. The track name column is now last by
default so that if it gets too wide you don't lose the others. It is
also marked as the expander column, so the expander widgets appear in
a more sensible place.
Richard Kettlewell [Fri, 13 Jun 2008 09:58:37 +0000 (10:58 +0100)]
Delay search initiation for a bit after the last keypress, to avoid
lots of bogus searches being started before the user has finished
typing.
Richard Kettlewell [Fri, 13 Jun 2008 09:26:41 +0000 (10:26 +0100)]
Make next/prev search result buttons work.
Gentler color for search results.
Richard Kettlewell [Thu, 12 Jun 2008 19:34:29 +0000 (20:34 +0100)]
TODOs for choose-search.c
Richard Kettlewell [Thu, 12 Jun 2008 19:29:33 +0000 (20:29 +0100)]
When listing a directory which contains an alias for a track in that
directory, it is now the alias that is skipped rather than the real
name. None of the possibilities here are very attractive but this one
seems to be easier to write UIs against.
Richard Kettlewell [Thu, 12 Jun 2008 19:27:42 +0000 (20:27 +0100)]
Make all search results visible.
Richard Kettlewell [Thu, 12 Jun 2008 16:24:47 +0000 (17:24 +0100)]
Start reimplenting search in Disobedience choose tabs. Results are
highlighted correctly but only if they are already visible. Focus is
still a bit wonky and ^A doesn't reliably go to the right place.
Richard Kettlewell [Thu, 12 Jun 2008 15:18:18 +0000 (16:18 +0100)]
Tidy up
Richard Kettlewell [Thu, 12 Jun 2008 15:17:29 +0000 (16:17 +0100)]
Eliminate choosedata structure, using extra treestore columns instead.
Richard Kettlewell [Thu, 12 Jun 2008 13:05:00 +0000 (14:05 +0100)]
add a TODO
Richard Kettlewell [Thu, 12 Jun 2008 12:49:06 +0000 (13:49 +0100)]
Playing checkbox in Disobedience choose tab is now only visible for
tracks, and can be used to add the track to the queue.
Richard Kettlewell [Thu, 12 Jun 2008 12:25:14 +0000 (13:25 +0100)]
Display track length and playing state in Disobedience choose tab. We
enable rules in this tab to allow for easy reading across now that
there's more than one column.
Richard Kettlewell [Thu, 12 Jun 2008 11:35:40 +0000 (12:35 +0100)]
Saner selection choice for popup menus.
- if the clicked row is already selected, leave the selection as it is
- if the click is not on any row, leave the selection as it is
- if the clicked row is not selected, select ONLY that row
Richard Kettlewell [Thu, 12 Jun 2008 11:28:45 +0000 (12:28 +0100)]
Disobedience choose 'select all' now only selects tracks (and
deselects directories).
Richard Kettlewell [Thu, 12 Jun 2008 10:57:34 +0000 (11:57 +0100)]
Set edit menu sensitivity when it is shown rather than when we change tab.
Richard Kettlewell [Thu, 12 Jun 2008 10:40:32 +0000 (11:40 +0100)]
Complete choose tab popup support (also middle-click).
Richard Kettlewell [Thu, 12 Jun 2008 10:18:39 +0000 (11:18 +0100)]
Start on popup menu for Disobedience choose tab. Mostly this is
restructing; the per-tab callbacks for the edit menu are now shared
with the popup menu, eliminating a lot of fiddly shims, and various
things are split out into their own files.
Richard Kettlewell [Thu, 12 Jun 2008 09:32:34 +0000 (10:32 +0100)]
Start rewriting Disobedience choose tab using native tree. Much
simpler so far though there is a shopping list of TODOs left yet.
Richard Kettlewell [Wed, 11 Jun 2008 17:18:19 +0000 (18:18 +0100)]
Documentation update
Richard Kettlewell [Wed, 11 Jun 2008 17:10:29 +0000 (18:10 +0100)]
Drag and drop queue rearrangement. Currently you can only move one
track at a time, which is a regression, but it's what the built-in
support gives us, unfortunately.
Richard Kettlewell [Wed, 11 Jun 2008 15:55:14 +0000 (16:55 +0100)]
Don't allocate per-queue tabtype. In fact the allocate version broken
intermittently (because GTK+ stupidly hides pointers from the GC) but
the change is to stop allocating altogether rather than to use
g_malloc().
Richard Kettlewell [Wed, 11 Jun 2008 14:17:19 +0000 (15:17 +0100)]
Update queues by rearranging rows, rather than by blowing them away
and reinstalling them.
Also, ensure that the queue never shows the playing track as in the
queue (by refetching until a good answer arrives).
Richard Kettlewell [Wed, 11 Jun 2008 12:00:05 +0000 (13:00 +0100)]
Make queue columns reorderable
Richard Kettlewell [Wed, 11 Jun 2008 11:40:02 +0000 (12:40 +0100)]
Play tracks from popup in new tracks list. The same code would work
for recent if anyone wanted it, but it seems odd to want to play
just-played tracks, so it's not used for that currently.
Richard Kettlewell [Wed, 11 Jun 2008 11:35:53 +0000 (12:35 +0100)]
Restore scratching from popup menu.
Richard Kettlewell [Wed, 11 Jun 2008 11:31:12 +0000 (12:31 +0100)]
Remove tracks now works again. queue_entry pointers are now stashed
in the list store, making this rather easier.
Richard Kettlewell [Wed, 11 Jun 2008 10:50:02 +0000 (11:50 +0100)]
Disobedience memory/widget debugging stuff has thoroughly rotted, so
rip it out.
Richard Kettlewell [Wed, 11 Jun 2008 10:21:38 +0000 (11:21 +0100)]
Leave a comment about iffy icon sensivity; it's definitely setting the
right thing so I think this is a GTK+ bug.
Richard Kettlewell [Wed, 11 Jun 2008 09:57:25 +0000 (10:57 +0100)]
Refetch queue on pause/resume so that start times are always right (or
absent if unknowable).
Richard Kettlewell [Wed, 11 Jun 2008 09:53:11 +0000 (10:53 +0100)]
Fix edit menu (and simplify its implementation a bit).
Richard Kettlewell [Tue, 10 Jun 2008 21:46:31 +0000 (22:46 +0100)]
Select hovered track if nothing is selected on right click over queue etc.
Richard Kettlewell [Tue, 10 Jun 2008 21:33:53 +0000 (22:33 +0100)]
Columns are now resizable and wide columns are ellipsized. Columns
more reliably get their right width.
NB http://bugzilla.gnome.org/show_bug.cgi?id=316087 applies here.
Amazingly, GTK+ column resizing is broken nearly three years after
someone reported it (and presumably in fact longer than that).
Richard Kettlewell [Tue, 10 Jun 2008 21:03:49 +0000 (22:03 +0100)]
Alternating row colors
Richard Kettlewell [Tue, 10 Jun 2008 21:01:46 +0000 (22:01 +0100)]
Fix queue/etc popup menu
Richard Kettlewell [Tue, 10 Jun 2008 20:13:25 +0000 (21:13 +0100)]
Rewrite queue/recent/added to use native list widget.
What works:
- the tracks are displayed correctly
- keyboard scrolling now works properly (at last!)
What doesn't work:
- popup menu is broken
- edit menu is unimplemented
- drag+drop is unimplemented
- columns are not resizable
- ellipsization is off
- no horizontal banding
- probably lots of other things
Richard Kettlewell [Mon, 9 Jun 2008 21:06:12 +0000 (22:06 +0100)]
Move RTP check. This seems to improve matters - formerly the RTP
status was set before DISORDER_CONNECTED was, leading to a false
negative. This is a bit of a voodoo-ish change l-(
Richard Kettlewell [Mon, 9 Jun 2008 19:57:58 +0000 (20:57 +0100)]
Icons now only get events that they are interested in.
Richard Kettlewell [Mon, 9 Jun 2008 08:54:34 +0000 (09:54 +0100)]
Encourage choose tab's input focus to the search box a bit. Really we
want up+down keys to go to the scrollable layout and everything else
to the search box but this is a start.
Richard Kettlewell [Mon, 9 Jun 2008 08:25:49 +0000 (09:25 +0100)]
Proper calculation of scratch/remove rights
Richard Kettlewell [Mon, 9 Jun 2008 08:21:36 +0000 (09:21 +0100)]
Check rights for menu items too
Richard Kettlewell [Mon, 9 Jun 2008 08:17:07 +0000 (09:17 +0100)]
Sensitize icons according to current user rights. There's up to 10s
latency in rights taking effect, which is unavoidable given the server
currently doesn't tell us when they change.
Richard Kettlewell [Mon, 9 Jun 2008 07:37:10 +0000 (08:37 +0100)]
Merge from disorder.4.0
Richard Kettlewell [Mon, 9 Jun 2008 07:35:03 +0000 (08:35 +0100)]
Update README* for current situation
Richard Kettlewell [Mon, 9 Jun 2008 07:22:50 +0000 (08:22 +0100)]
Switch Disobedience reset (i.e. fresh login) notification over to
event_() functions.
Richard Kettlewell [Mon, 9 Jun 2008 07:08:35 +0000 (08:08 +0100)]
Install CGI correctly.
Richard Kettlewell [Mon, 9 Jun 2008 06:44:30 +0000 (07:44 +0100)]
Tidy up makefile
Richard Kettlewell [Mon, 9 Jun 2008 06:39:50 +0000 (07:39 +0100)]
Rearrange crazy control.c logic. No longer are there two widgets per
icon with one always invisible, instead we change the contained image
when we want to change state.
We still redo all the icons when only one changes state, which could
possibly be improved but is at least robust and comprehensible.
Richard Kettlewell [Sun, 8 Jun 2008 21:39:31 +0000 (22:39 +0100)]
Catch up on a missing bit of eclient API change
Richard Kettlewell [Sun, 8 Jun 2008 21:17:25 +0000 (22:17 +0100)]
Complete Disobedience transition to event_ from _monitor.
Richard Kettlewell [Sun, 8 Jun 2008 19:52:17 +0000 (20:52 +0100)]
Start Disobedience switch from _monitor interface to event_ interface.
Richard Kettlewell [Sun, 8 Jun 2008 19:51:50 +0000 (20:51 +0100)]
Force -std=gnu99. If we're going to require GCC anyway we might as
well get the full benefit.
Richard Kettlewell [Sun, 8 Jun 2008 16:59:28 +0000 (17:59 +0100)]
More event_*
Richard Kettlewell [Sun, 8 Jun 2008 16:53:55 +0000 (17:53 +0100)]
Start using event_*() calls in Disobedience.
Richard Kettlewell [Sun, 8 Jun 2008 14:58:52 +0000 (15:58 +0100)]
Further eclient error API change.
Richard Kettlewell [Sun, 8 Jun 2008 13:46:19 +0000 (14:46 +0100)]
Set Debian version to 4.0 too
Richard Kettlewell [Sun, 8 Jun 2008 13:15:18 +0000 (14:15 +0100)]
disorder_eclient_queue_response now gets error as well as success
responses.
Richard Kettlewell [Sun, 8 Jun 2008 13:13:52 +0000 (14:13 +0100)]
Quieten gcc 4.3
Richard Kettlewell [Sun, 8 Jun 2008 13:04:49 +0000 (14:04 +0100)]
Add a missing LIBGC
Richard Kettlewell [Sun, 8 Jun 2008 12:57:28 +0000 (13:57 +0100)]
Quieten compiler.
Richard Kettlewell [Sun, 8 Jun 2008 12:56:03 +0000 (13:56 +0100)]
disorder-udplog needs GC
Richard Kettlewell [Sun, 8 Jun 2008 12:44:34 +0000 (13:44 +0100)]
Don't use deprecated ALSA calls (since they generate warnings, which
breaks with -Werror). Stupid ALSA.
Richard Kettlewell [Sun, 8 Jun 2008 12:22:52 +0000 (13:22 +0100)]
Change version number to 4.0.
Richard Kettlewell [Sun, 8 Jun 2008 12:13:17 +0000 (13:13 +0100)]
Report disorder_eclient_volume() errors to the specific callback.
(Untested for now.)
Richard Kettlewell [Sun, 8 Jun 2008 12:06:03 +0000 (13:06 +0100)]
eclient integer callbacks now get errors instead of using generic
protocol error callback.
Richard Kettlewell [Sun, 8 Jun 2008 10:49:49 +0000 (11:49 +0100)]
eclient no_response calls all now have errors reported to the per-call
callback rather than the generic one. Slightly less convenient due to
the formerly widespread practice of passing a null callback, which is
now prohibited.
Richard Kettlewell [Sun, 8 Jun 2008 10:49:21 +0000 (11:49 +0100)]
Add kvp_make(), to make a kvp list in a single function call.
Richard Kettlewell [Sat, 7 Jun 2008 21:05:15 +0000 (22:05 +0100)]
eclient string response calls now get errors reported to the completed
callback rather than the protocol_error callback.
Richard Kettlewell [Sat, 7 Jun 2008 19:13:59 +0000 (20:13 +0100)]
TODOs for all the protocol_error() calls that need fixed
Richard Kettlewell [Sat, 7 Jun 2008 18:53:25 +0000 (19:53 +0100)]
General-purpose event distribution interface
Richard Kettlewell [Sat, 7 Jun 2008 15:50:25 +0000 (16:50 +0100)]
Don't stomp on choose widhet's submenu's color scheme
Richard Kettlewell [Fri, 6 Jun 2008 18:15:42 +0000 (19:15 +0100)]
scripts/teardown.in no longer removes things that are (now) installed
by the makefiles.
Richard Kettlewell [Fri, 6 Jun 2008 16:36:59 +0000 (17:36 +0100)]
Mention remote_userman bug in disobedience.1
Richard Kettlewell [Fri, 6 Jun 2008 16:30:19 +0000 (17:30 +0100)]
Make menu_update() robust against being called before the notebook has
been created.
Richard Kettlewell [Fri, 6 Jun 2008 15:46:45 +0000 (16:46 +0100)]
Add jukebox user to audio group in debian setup
Richard Kettlewell [Fri, 6 Jun 2008 12:49:15 +0000 (13:49 +0100)]
More automation of web interface installation
Richard Kettlewell [Fri, 6 Jun 2008 11:13:46 +0000 (12:13 +0100)]
Fix another stupid in @dirs...
Richard Kettlewell [Fri, 6 Jun 2008 11:12:03 +0000 (12:12 +0100)]
force cgidir so we can build on a system without a web swerver
Richard Kettlewell [Fri, 6 Jun 2008 09:33:05 +0000 (10:33 +0100)]
Fix display of play/edit all in choose.tmpl
Richard Kettlewell [Fri, 6 Jun 2008 09:27:16 +0000 (10:27 +0100)]
Automate installation of the CGI at last.
configure will try to guess the install location, if it can't then you
can set cgidir=/path/to/cgi-bin to override it.
Richard Kettlewell [Thu, 5 Jun 2008 18:07:52 +0000 (19:07 +0100)]
remove css cruft for long-gone separate search page
Richard Kettlewell [Thu, 5 Jun 2008 18:05:35 +0000 (19:05 +0100)]
Missed an action button in earlier changes
Richard Kettlewell [Thu, 5 Jun 2008 18:03:30 +0000 (19:03 +0100)]
Correct file exposed by @dirs and @files!
Richard Kettlewell [Thu, 5 Jun 2008 14:54:38 +0000 (15:54 +0100)]
Tidy up search form; remove cruft
Richard Kettlewell [Thu, 5 Jun 2008 14:45:01 +0000 (15:45 +0100)]
Style button as well. Consistent in IE and FF, a bit off in Safari.
Richard Kettlewell [Thu, 5 Jun 2008 14:38:44 +0000 (15:38 +0100)]
Use form-based buttons instead of hyperlinks
Richard Kettlewell [Thu, 5 Jun 2008 14:15:59 +0000 (15:15 +0100)]
Macro-ize (most) <A>-based buttons
Richard Kettlewell [Thu, 5 Jun 2008 11:21:42 +0000 (12:21 +0100)]
Clean up properly in postrm.
For --remove we just remove cached data and infrastructure.
For --purge we remove everything.
Richard Kettlewell [Wed, 4 Jun 2008 09:31:45 +0000 (10:31 +0100)]
Macroize submit buttons so we can mess with them more easily
Richard Kettlewell [Wed, 4 Jun 2008 08:23:05 +0000 (09:23 +0100)]
Verify --help/--version for disorder-choose
Richard Kettlewell [Wed, 4 Jun 2008 08:16:08 +0000 (09:16 +0100)]
Fiddle with CSS+HTML in effort to get more consistent buttons
Richard Kettlewell [Tue, 3 Jun 2008 18:11:46 +0000 (19:11 +0100)]
Improve button appearance (slightly) in IE7
Richard Kettlewell [Tue, 3 Jun 2008 17:53:07 +0000 (18:53 +0100)]
Restore track length in CGI
Richard Kettlewell [Tue, 3 Jun 2008 17:48:28 +0000 (18:48 +0100)]
Correct title attribute for @onoff controls
Richard Kettlewell [Tue, 3 Jun 2008 17:46:22 +0000 (18:46 +0100)]
Correct back= URL for volume setting
Richard Kettlewell [Tue, 3 Jun 2008 17:42:25 +0000 (18:42 +0100)]
Don't report failure just because MTA is being over-picky
Richard Kettlewell [Tue, 3 Jun 2008 17:34:18 +0000 (18:34 +0100)]
Add missing type attribute in login.tmpl. Only IE7 noticed.
Richard Kettlewell [Tue, 3 Jun 2008 17:09:20 +0000 (18:09 +0100)]
Debian packaging changes:
- disorder-server now depends on mail-transport-agent
- disorder-server no longer asks for an SMTP server
(instead uses local /usr/sbin/sendmail)
- remove /etc/disorder/conf.debconf on purge