From: Richard Kettlewell <rjk@greenend.org.uk>
Date: Mon, 23 Nov 2009 09:40:20 +0000 (+0000)
Subject: Preserve playlist selection when list changes
X-Git-Tag: 5.0~45^2~26
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~mdw/git/disorder/commitdiff_plain/d571e07bdeab0ed6ad0b3946c25ecab2c11132e6?ds=inline

Preserve playlist selection when list changes
---

diff --git a/disobedience/playlists.c b/disobedience/playlists.c
index 4aacfb9..31576ad 100644
--- a/disobedience/playlists.c
+++ b/disobedience/playlists.c
@@ -456,15 +456,20 @@ static void playlists_fill(const char attribute((unused)) *event,
                            void attribute((unused)) *callbackdata) {
   GtkTreeIter iter[1];
 
+  if(!playlists_window)
+    return;
   if(!playlists_list)
     playlists_list = gtk_list_store_new(1, G_TYPE_STRING);
-  gtk_list_store_clear(playlists_list);
-  for(int n = 0; n < nplaylists; ++n)
+  const char *was_selected = playlists_selected;
+  gtk_list_store_clear(playlists_list); /* clears playlists_selected */
+  for(int n = 0; n < nplaylists; ++n) {
     gtk_list_store_insert_with_values(playlists_list, iter, n/*position*/,
                                       0, playlists[n],        /* column 0 */
                                       -1);                    /* no more cols */
-  // TODO reselect whatever was formerly selected if possible, if not then
-  // zap the contents view
+    /* Reselect the selected playlist */
+    if(was_selected && !strcmp(was_selected, playlists[n]))
+      gtk_tree_selection_select_iter(playlists_selection, iter);
+  }
 }
 
 /** @brief Called when the selection might have changed */