From: Richard Kettlewell <rjk@greenend.org.uk>
Date: Sat, 28 Jun 2008 12:13:36 +0000 (+0100)
Subject: Correct user management window widget lifetime
X-Git-Tag: 4.1~1
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~mdw/git/disorder/commitdiff_plain/c7a260fbdb435de07299985dc58aec08713d582e

Correct user management window widget lifetime
---

diff --git a/disobedience/users.c b/disobedience/users.c
index 60bdef6..a835ced 100644
--- a/disobedience/users.c
+++ b/disobedience/users.c
@@ -645,6 +645,8 @@ static GtkWidget *users_make_reporter() {
     users_reporter = gtk_label_new("");
     gtk_label_set_ellipsize(GTK_LABEL(users_reporter), PANGO_ELLIPSIZE_END);
     gtk_misc_set_alignment(GTK_MISC(users_reporter), 0.99, 0);
+    g_signal_connect(users_reporter, "destroy",
+                     G_CALLBACK(gtk_widget_destroyed), &users_reporter);
   }
   return users_reporter;
 }
@@ -681,6 +683,9 @@ void manage_users(void) {
     gtk_window_present(GTK_WINDOW(users_window));
     return;
   }
+  /* Destroy old widgets */
+  if(users_reporter)
+    gtk_widget_destroy(users_reporter);
   /* Create the window */
   users_window = gtk_window_new(GTK_WINDOW_TOPLEVEL);
   gtk_widget_set_style(users_window, tool_style);